Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve StoredCredential.Descriptor at access(?) #528

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

abergs
Copy link
Collaborator

@abergs abergs commented Jul 15, 2024

While we might want to cache it, this is to simplify the concept so that devs more easier understand how the piecies fit toghether"

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@df37692). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #528   +/-   ##
=========================================
  Coverage          ?   74.04%           
=========================================
  Files             ?      100           
  Lines             ?     2655           
  Branches          ?      446           
=========================================
  Hits              ?     1966           
  Misses            ?      588           
  Partials          ?      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs
Copy link
Collaborator Author

abergs commented Jul 15, 2024

@Regenhardt Does this perhaps strike a good balance on your original concerns in #510

@Regenhardt
Copy link
Contributor

Thanks for the ping, yes this is a nice solution for the redundancy. Could use an XML summary on the descriptor and maybe on the Id mentioning it as being the actual public key or something.

@abergs abergs merged commit 184f70f into master Jul 16, 2024
11 checks passed
@abergs abergs deleted the simplify-storedCredential branch July 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants