Fatal exceptions should still cause resource disposal

[argv-minus-one]

The use of Try and NonFatal in the ARM code is a bad idea. Besides things like StackOverflowError, NonFatal also excludes NonLocalReturnControl, which is used by the compiler to implement non-local return. As a result, a non-local return through ARM will leak file handles.

Please use try…finally (and Throwable#addSuppressed, as appropriate) instead, like Java try-with-resources does.

[pathikrit]

Fixed in #159. Try v3.1.0

[argv-minus-one]

I was using 3.1.0. This problem is not fixed; scala.util.Try ignores fatal exceptions.

I'm working on a PR to solve this problem for real.

[pathikrit]

A small proof-of-concept of code snippet to illustrate problem would be fine here.

[pathikrit]

I am curious - I don't have any NonFatal in the codebase ...

[argv-minus-one]

You do have scala.util.Try in the codebase. Try uses NonFatal.

I'm working on debugging some tests I wrote. One of them should demonstrate the problem with the original code. Stand by.

[argv-minus-one]

I have posted PR #175 to address this issue.

[pathikrit]

@argv-minus-one : Thanks for the PR. I did some DRYing up of the code. Can you please take a look here: #178