- Linting: Nuke unused var.; specify more param types

pathscale · Oct 6, 2020 · 6632799 · 6632799
1 parent 420f944
commit 6632799
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/src/components/compounds/Table/DataGrid.ts b/src/components/compounds/Table/DataGrid.ts
@@ -45,7 +45,7 @@ class DataGrid {
     }
   }
 
-  deleteRow(index) {
+  deleteRow(index: number) {
     this.rows.splice(index, 1)
     this.originalRows.splice(index, 1)
   }
@@ -96,20 +96,20 @@ class DataGrid {
     this.draggingRowIdx = idx;
   }
 
-  onDropRow(event, row, idx: number) {
+  onDropRow(evt: Event, row, idx: number) {
     const chunk = this.rows.splice(this.draggingRowIdx, 1)
     this.rows.splice(idx, 0, chunk[0])
     this.resetDraggingRow()
   }
 
-  onDragOverRow(event, row, idx: number) {
+  onDragOverRow(evt: Event, row, idx: number) {
     if (this.draggingRowIdx === null) return;
 
     this.rows[idx].selected = true
-    event.preventDefault()
+    evt.preventDefault()
   }
 
-  onDragLeaveRow(event, row, idx) {
+  onDragLeaveRow(evt: Event, row, idx) {
     this.rows[idx].selected = false
   }
 
@@ -119,27 +119,27 @@ class DataGrid {
     this.draggingRowIdx = null;
   }
 
-  onDragStartColumn(event, column, idx: number) {
+  onDragStartColumn(evt: Event, column, idx: number) {
     this.draggingColumn = column;
     this.draggingColumnIdx = idx;
   }
 
   // callback called when user drops a column
-  onDropColumn(event, column, idx: number) {
+  onDropColumn(evt: Event, column, idx: number) {
     const chunk = this.columns.splice(this.draggingColumnIdx, 1)
     this.columns.splice(idx, 0, chunk[0])
     this.resetDraggingColumn()
   }
 
   // the event must be prevented for the onDrop method to get called
-  onDragOverColumn(event, column, idx: number) {
+  onDragOverColumn(evt: Event, column, idx: number) {
     if (this.draggingColumnIdx === null) return;
 
     this.columns[idx].selected = true
-    event.preventDefault()
+    evt.preventDefault()
   }
 
-  onDragLeaveColumn(event, column, idx: number) {
+  onDragLeaveColumn(evt: Event, column, idx: number) {
     this.columns[idx].selected = false
   }
 

diff --git a/src/components/compounds/Table/Table.vue b/src/components/compounds/Table/Table.vue
@@ -40,7 +40,6 @@ const Table = {
   setup(props, { emit }) {
     // datagrid instance reference
     const data = ref(props.data)
-    const pagination = ref(props.pagination)
     const rowsPerPage = ref(props.rowsPerPage)
     const currentPage = ref(0)
     const search = reactive({})