Roughness-adjusted fresnel. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice improvement! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a roughness-adjusted fresnel function. This function has been described by Sébastien Lagarde and others.
The rationale is as follows: "Applying Fresnel term to prefiltered cubemap has a bad effect of always showing high specular color at edge, even for rough surface.... We approximate this “fresnel attenuation” empirically by introducing a fudge factor (taking count of gloss) in fresnel equation to get pleasant visual result"
This produces significant improvements when applied to the indirect components of a PBR shader.
For more details, see Lagarde's blog post.
https://seblagarde.wordpress.com/2011/08/17/hello-world/