Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod doesn't exist in hlsl, need to use fmod #7

Merged
merged 1 commit into from
May 24, 2021
Merged

mod doesn't exist in hlsl, need to use fmod #7

merged 1 commit into from
May 24, 2021

Conversation

couleurs
Copy link
Contributor

No description provided.

@patriciogonzalezvivo
Copy link
Owner

I love you pibe. Keep it comming!

@patriciogonzalezvivo patriciogonzalezvivo merged commit 5be3cd7 into patriciogonzalezvivo:main May 24, 2021
@SabinT
Copy link
Contributor

SabinT commented Jul 4, 2021

Not sure if this matters for the attached commit, but hlsl fmod produces a different output than glsl mod for negative numbers. Does it make sense for color values to be negative? If not, then non issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@couleurs @patriciogonzalezvivo @SabinT