Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update amqplib #3

Merged
merged 1 commit into from
Jun 8, 2021
Merged

update amqplib #3

merged 1 commit into from
Jun 8, 2021

Conversation

KevinBierende
Copy link
Contributor

No description provided.

@patrickd-
Copy link
Owner

patrickd- commented Jun 8, 2021

Thanks for your suggestion Kevin. It's indeed about time to update this module. There are a few more things that need to be done though.


Possibly problematic changes in amqplib:

  • v0.8.0: Support for NodeJS prior to v10 is dropped (PR 615)
  • v0.5.5: NB this includes a minor but possibly breaking change: after PR 498, all confirmation promises still unresolved will be rejected when their associated channel is closed.

Todo

  • wrappitmq version should be bumped from 1.0.7 to 1.1.0 to reflect possible breaking changes.
  • possible breaking changes should be listed within readme
  • node engine requirement in package.json should be raised to ">=10" to reflect amqplib

To make things easier I'll just go ahead and merge this and make the other changes myself before publishing the package to npm

@patrickd- patrickd- merged commit 88ff5a2 into patrickd-:master Jun 8, 2021
@patrickd-
Copy link
Owner

Has been published to npm as v1.1.0

should be visible once the cache updates
https://www.npmjs.com/package/wrappitmq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants