Skip to content

Commit

Permalink
Remove dependency check and improve gihtub actions
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickfav committed Feb 15, 2023
1 parent ec8487d commit 4c3bc49
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/build_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ jobs:
java-version: '17'
distribution: 'temurin'
- name: Build with Maven
run: ./mvnw -B clean package checkstyle:checkstyle -DcommonConfig.jarSign.skip=true
- name: Collect Code Coverage # for any reason JaCoCo fails if it is done in a single step
run: ./mvnw -B jacoco:report
run: ./mvnw -B clean verify -DcommonConfig.jarSign.skip=true
- name: Analyze with SonaQube
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
Expand Down Expand Up @@ -73,7 +71,7 @@ jobs:
java-version: '17'
distribution: 'temurin'
- name: Build with Maven
run: ./mvnw -B package
run: ./mvnw -B verify
- name: Create and upload Github Release
uses: xresloader/upload-to-github-release@v1
env:
Expand Down
6 changes: 1 addition & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<version>1.2.2</version>

<properties>
<commonConfig.jarSign.skip>false</commonConfig.jarSign.skip>
<commonConfig.jarSign.skip>true</commonConfig.jarSign.skip>
<!-- TODO until we fix https://github.com/patrickfav/uber-apk-signer/issues/24 -->
<commonConfig.jacoco.check.disable>true</commonConfig.jacoco.check.disable>
<!-- SonarQube Config -->
Expand Down Expand Up @@ -81,10 +81,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.owasp</groupId>
<artifactId>dependency-check-maven</artifactId>
</plugin>
<plugin>
<groupId>com.googlecode.addjars-maven-plugin</groupId>
<artifactId>addjars-maven-plugin</artifactId>
Expand Down

0 comments on commit 4c3bc49

Please sign in to comment.