Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(starterkit-twig-demo): pages not rendering pattern-specific data … #1490

Merged
merged 1 commit into from
Feb 26, 2023
Merged

fix(starterkit-twig-demo): pages not rendering pattern-specific data … #1490

merged 1 commit into from
Feb 26, 2023

Conversation

hadl
Copy link
Contributor

@hadl hadl commented Feb 26, 2023

…from json

Closes: #1486

Summary of changes:

  • Fixed JSON structure/data and passing to Twig includes.
  • Moved _macros folder to _pattern/macros directory to prevent linage notices
  • pages/*.json tabs -> spaces

@JosefBredereck
Copy link
Contributor

This fix is much appreciated 🚀

@JosefBredereck JosefBredereck merged commit 1c878df into pattern-lab:dev Feb 26, 2023
@hadl hadl deleted the feature/1486-fix-broken-twig-starterkit branch March 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosefBredereck JosefBredereck JosefBredereck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken starter kit Twig Demo
2 participants
@hadl @JosefBredereck