RHCLOUD-31230 Adding virtual-assistant's body #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josejulio
commented
Mar 19, 2024
...ntent/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantWithActions.tsx
Show resolved
Hide resolved
fhlavac
reviewed
Mar 20, 2024
|
Looks like the md lint is failing also in main: https://github.com/patternfly/virtual-assistant/actions/runs/8143791510/job/22256489065 - pr preview seems busted as well. |
epwinchell
approved these changes
Mar 21, 2024
|
@josejulio thank you, I see. Will try to figure it out. Maybe @dlabaj could help us |
|
@josejulio this might help #6 |
- Adding tests - Moved to managed component and added new props
josejulio
force-pushed
the
RHCLOUD-31230
branch
from
c76737b to
6289c6a
Compare
|
Rebased, only the pr-preview is failing (expected as not configured) |
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Can you please add 'VirtualAssistantActions' to propComponents? It shows the component's props in the docs.
There was a problem hiding this comment.
Tried, but it doesn't look good (it's not adding all the attributes), it's probably going to cause more confusion.
I think the reason is because I'm using the same props as Button.
I'll add it if you think that's fine.
export type VirtualAssistantActionProps = ButtonProps;
There was a problem hiding this comment.
Hmm, yeah, it looks weird, let's not add it for now. I'll reach out to PF on how we could display such types properly. Thank you 🙂
fhlavac
reviewed
Mar 21, 2024
...ontent/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantCustomText.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...ontent/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantCustomText.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...ontent/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantCustomText.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...ontent/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantCustomText.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...xtensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantDisableOnEmptyText.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
.../content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantMessages.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Mar 21, 2024
...ntent/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistantWithActions.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
fhlavac
reviewed
Mar 21, 2024
fhlavac
reviewed
Mar 21, 2024
fhlavac
reviewed
Mar 21, 2024
|
@josejulio made some nitpicking there 😄 |
Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
epwinchell
approved these changes
Mar 21, 2024
fhlavac
approved these changes
Mar 22, 2024
|
🎉 This PR is included in version 1.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using some of the changes from #3 (Thanks @epwinchell !)