Chat bubbles #7
Merged
Chat bubbles #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekkaluzik
force-pushed
the
RHCLOUD-31241
branch
3 times, most recently
from
a533ced to
7b1380d
Compare
josejulio
reviewed
Mar 27, 2024
...tent/extensions/virtual-assistant/examples/VirtualAssistant/AssistantMessageWithFollowup.tsx
Outdated
Show resolved
Hide resolved
|
@radekkaluzik if this one gets merged after #11 could you please add a test case for your part? |
radekkaluzik
force-pushed
the
RHCLOUD-31241
branch
2 times, most recently
from
d48a6aa to
bac1a00
Compare
|
@fhlavac I can't add reviewers. Could you please take a look at this PR. Thanks. |
fhlavac
reviewed
Apr 17, 2024
packages/module/src/AssistantMessageEntry/AssistantMessageEntry.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Apr 17, 2024
packages/module/src/AssistantMessageEntry/AssistantMessageEntry.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Apr 17, 2024
packages/module/src/AssistantMessageEntry/AssistantMessageEntry.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Apr 17, 2024
packages/module/src/AssistantMessageEntry/AssistantMessageEntry.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Apr 17, 2024
packages/module/src/AssistantMessageEntry/AssistantMessageEntry.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Apr 17, 2024
...nfly-docs/content/extensions/virtual-assistant/examples/VirtualAssistant/VirtualAssistant.md
Outdated
Show resolved
Hide resolved
|
Some smaller comments, apart from that looks great! 🎉 |
radekkaluzik
force-pushed
the
RHCLOUD-31241
branch
from
bac1a00 to
cdc2ef9
Compare
|
@radekkaluzik looks good! Just if you could take a look at the remaining comments and we can merge then |
josejulio
requested changes
Apr 19, 2024
packages/module/src/AssistantMessageEntry/AssistantMessageEntry.tsx
Outdated
Show resolved
Hide resolved
packages/module/src/AssistantMessageEntry/AssistantMessageEntry.tsx
Outdated
Show resolved
Hide resolved
radekkaluzik
force-pushed
the
RHCLOUD-31241
branch
from
cdc2ef9 to
2528089
Compare
fhlavac
approved these changes
Apr 26, 2024
josejulio
approved these changes
Apr 26, 2024
| @@ -34,6 +34,7 @@ | |||
| "@patternfly/react-core": "^5.1.2", | |||
| "@patternfly/react-icons": "^5.1.2", | |||
| "react-jss": "^10.10.0", | |||
| "react-markdown": "^9.0.1", | |||
There was a problem hiding this comment.
Is this required? if not, we can get rid of it.
|
🎉 This PR is included in version 1.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHCLOUD-31241