Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - MenuToggleCheckbox - events not generated when clicking on text #10035

Closed
dlabrecq opened this issue Jan 23, 2024 · 1 comment · Fixed by #10066
Closed

Bug - MenuToggleCheckbox - events not generated when clicking on text #10035

dlabrecq opened this issue Jan 23, 2024 · 1 comment · Fixed by #10066
Assignees
Milestone

Comments

@dlabrecq
Copy link
Member

Trying to replace the deprecated Dropdown, for an existing bulk select, and running into trouble.

After a selection, the user cannot click on the "10 selected" text below to expand the list. We can only click on the down arrow to expand the list.

chrome-capture-2024-0-23

As a workaround, I wrapped the "10 selected" text in a span and used its onClick to open the list. However, this does not seem correct. I expected the onClick of MenuToggle to be triggered.

Notes

When the text is clicked:

  • the onSelect of Dropdown isn't called
  • the onClick of MenuToggle isn't called
  • neither onChange or onClick of MenuToggleCheckbox are called

With the older, deprecated Dropdown / DropdownToggleCheckbox, I'm able to click anywhere on the text / dropdown.

Code
Screenshot 2024-01-23 at 11 13 22 AM

@dlabrecq
Copy link
Member Author

I'm able to replicate the issue with the bulk select codesandbox example below
https://codesandbox.io/p/sandbox/proud-glitter-cw5v7h

@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Jan 25, 2024
@tlabaj tlabaj added this to the Prioritized Backlog milestone Jan 25, 2024
@wise-king-sullyman wise-king-sullyman moved this from Backlog to Not started in PatternFly Issues Jan 31, 2024
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Feb 6, 2024
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues Feb 6, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants