Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior #10066

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Feb 6, 2024

What: Closes #10034 and #10035

For 10034 - checked needed to use the result of calculateChecked instead of just the isChecked prop (because null needs to be re-resolved to false to prevent the issue).

For 10035 - This one is a little tricky, because the new toggle structure was not set up to wrap or pass the toggle click handler to the splitButtonItems. I've opted to put the onClick on the outer div wrapper, and prevent propagation in the splitButtonItems (on the action button and checkbox input specifically), but we may want to consider which behavior we want. We can use the changes in the PR currently (the whole div becomes clickable), or make the checkbox label text click trigger the checkbox input change handler instead (keeping the toggle button as the only toggle click handler), or let a user pass the onClick manually to the MenuToggleCheckbox.

@kmcfaul kmcfaul linked an issue Feb 6, 2024 that may be closed by this pull request
@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 6, 2024

@tlabaj tlabaj requested review from a team, wise-king-sullyman and mfrances17 and removed request for a team February 13, 2024 20:45
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently clicking the down caret icon calls the onClick twice (clicking the "X selected" text calls it only once). Looks like it just needs another stopPropagation on the button in the split button wrapper.

I think this may be partially an issue with the markup. The original issue for the onClick portion has trhe expectation that clicking the "10 selected" text would trigger the onClick of the toggle (i.e. expand it). The markup, however, has this text as part of the label element, which I would expect clicking that text to toggle the checkbox state/call the onChange callback.

I wouldn't be opposed to this as a temporary solution, but as a more permanent solution I don't think we should place an onClick on the div wrapper (even though right now it doesn't seem like there's anything preventing keyboard interaction as you'd expect; the down caret icon receives focus for the MenuToggle onClick, and the checkbox receives focus for its onChange). Instead we should go with what you proposed above (having the text trigger the onChange of the checkbox) or consider moving that split button text inside the button element instead of the label to then trigger the MenuToggle's onClick (and then link that text to the label with for/id attributes).

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Feb 28, 2024

@mattnolting

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Mar 25, 2024

Per working session conversation, I'm adjusting the click changes to not use a click event on the outer div (which doesn't really make sense and would cause some accessibility issues). Now, clicking the text should check/uncheck the checkbox, as is the usual behavior for checkboxes with labels. Toggling can only be done with the toggle button for splitButtonAction toggles because the behavior is divided between two interactive elements.

@kmcfaul kmcfaul force-pushed the menutogglecheckbox-fixes branch from c6e578b to 2772aae Compare March 25, 2024 15:53
@mattnolting mattnolting self-requested a review March 25, 2024 18:35
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a comment in patternfly/patternfly#6317 just to mention the convo from here, more of a followup to look into the markup of the split button toggle with text.

@thatblindgeye thatblindgeye merged commit 132939e into patternfly:main Mar 26, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@7.3.0-prerelease.6
  • @patternfly/react-code-editor@5.3.0-prerelease.16
  • @patternfly/react-core@5.3.0-prerelease.14
  • @patternfly/react-docs@6.3.0-prerelease.19
  • @patternfly/react-drag-drop@5.3.0-prerelease.14
  • @patternfly/react-icons@5.3.0-prerelease.3
  • @patternfly/react-integration@5.1.1-prerelease.21
  • demo-app-ts@5.1.1-prerelease.88
  • @patternfly/react-styles@5.3.0-prerelease.3
  • @patternfly/react-table@5.3.0-prerelease.15
  • @patternfly/react-tokens@5.3.0-prerelease.3

Thanks for your contribution! 🎉

dlabaj added a commit that referenced this pull request Apr 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* fix(RTL): added right-to-left page demo (#9694)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.20
 - @patternfly/react-core@5.2.0-prerelease.20
 - @patternfly/react-docs@6.2.0-prerelease.20
 - demo-app-ts@5.1.1-prerelease.43
 - @patternfly/react-table@5.2.0-prerelease.20

* fix(Wizard): onStepChange - skip isDisabled & isHidden (#9748)

* fix(Text input): Added aria-expanded (#9705)

* fix(Text input): Added aria-expanded

* add interface

* updates from review

* fix(Notification Drawer): Added screen reader text for notification drawer item read state (#9569)

* fix(Notification Drawer): Added screen reader text for notification drawer item read state

* fix snapshot

* Update prop description

* add aria-live

* update snapshots

* feat(Wizard): ability to add props to WizardFooter buttons (#9709)

* feat: ability to add props to WizardFooter buttons

* fix(WizardFooter): null check

* fix(Wizard): simpler design of adding footer buttons props

* test(Wizard): can add props to footer buttons

* docs(WizardFooter): move comment so docs have correct description

* refactor(WizardFooter): move FooterButtonProps to types file

* chore(Divider): update tests to new standards (#9714)

* chore(Divider): update tests to new standards

* changes from PR review

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.21
 - @patternfly/react-core@5.2.0-prerelease.21
 - @patternfly/react-docs@6.2.0-prerelease.21
 - demo-app-ts@5.1.1-prerelease.44
 - @patternfly/react-table@5.2.0-prerelease.21

* fix(TreeView): define button type (#9770)

* bug(build): fixed built ESM files importing CJS files from react-styles (#9347)

* bug(build): fixed built ESM files importing CJS files from react-styles

* edited yarn.lock to invalidate deps cache in GH actions

* excluded file extensions from react-styles path transform in ESM build

* updated jest config to transform .mjs files

* updated pr action to invalidate deps cache if package files added/edited

* chore(deps): Add ts-node to support executing typescript files directly

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.22
 - @patternfly/react-core@5.2.0-prerelease.22
 - @patternfly/react-docs@6.2.0-prerelease.22
 - demo-app-ts@5.1.1-prerelease.45
 - @patternfly/react-table@5.2.0-prerelease.22
 - transformer-react-styles-esm-imports@1.0.1-prerelease.0

* chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.4 (#9780)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.6
 - @patternfly/react-code-editor@5.2.0-prerelease.23
 - @patternfly/react-core@5.2.0-prerelease.23
 - @patternfly/react-docs@6.2.0-prerelease.23
 - @patternfly/react-icons@5.2.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.46
 - @patternfly/react-styles@5.2.0-prerelease.4
 - @patternfly/react-table@5.2.0-prerelease.23
 - @patternfly/react-tokens@5.2.0-prerelease.5

* feat(Datalist): implement full page Basic demo to match HTML #9048 (#9087)

* feat(Datalist): implement full page Basic demo to match HTML #9048

* fix syntax error

* comments applied

* comments applied

* comments applied

* comments applied

* \xa0 comments applied

* move key per review comments

* address PR comments

* revert change to package.json

* Converted basic demo to TS

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>
Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>

* fix(ClipboardCopy): kepp caret position (#9772)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.24
 - @patternfly/react-core@5.2.0-prerelease.24
 - @patternfly/react-docs@6.2.0-prerelease.24
 - demo-app-ts@5.1.1-prerelease.47
 - @patternfly/react-table@5.2.0-prerelease.24

* chore(deps): update devdependencies (#9757)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.5 (#9806)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update devdependencies (#9800)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.7
 - @patternfly/react-code-editor@5.2.0-prerelease.25
 - @patternfly/react-core@5.2.0-prerelease.25
 - @patternfly/react-docs@6.2.0-prerelease.25
 - @patternfly/react-icons@5.2.0-prerelease.7
 - demo-app-ts@5.1.1-prerelease.48
 - @patternfly/react-styles@5.2.0-prerelease.5
 - @patternfly/react-table@5.2.0-prerelease.25
 - @patternfly/react-tokens@5.2.0-prerelease.6

* fix(DatePicker): updated logic for parsing and focus management (#9794)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.26
 - @patternfly/react-core@5.2.0-prerelease.26
 - @patternfly/react-docs@6.2.0-prerelease.26
 - demo-app-ts@5.1.1-prerelease.49
 - @patternfly/react-table@5.2.0-prerelease.26

* chore(PrimaryDetail): convert demos to TS (#9787)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.27
 - @patternfly/react-core@5.2.0-prerelease.27
 - @patternfly/react-docs@6.2.0-prerelease.27
 - demo-app-ts@5.1.1-prerelease.50
 - @patternfly/react-table@5.2.0-prerelease.27

* chore(misc): clean up instances of Array.apply (#9798)

* clean up instances of Array.apply

* rename item to value

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.28
 - @patternfly/react-core@5.2.0-prerelease.28
 - @patternfly/react-docs@6.2.0-prerelease.28
 - @patternfly/react-integration@5.1.1-prerelease.15
 - demo-app-ts@5.1.1-prerelease.51
 - @patternfly/react-table@5.2.0-prerelease.28

* chore(eslint): Added React Testing Library linter plugin (#9805)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.29
 - @patternfly/react-core@5.2.0-prerelease.29
 - @patternfly/react-docs@6.2.0-prerelease.29
 - @patternfly/react-icons@5.2.0-prerelease.8
 - demo-app-ts@5.1.1-prerelease.52
 - @patternfly/react-table@5.2.0-prerelease.29

* chore(DataList): update tests (#9672)

* add spread prop test, update test

* chore(DataList): update tests

* fix merge error

* break out into separate files, pr feedback

* updates

* fix some example ids

* minor test updates

* revert action change

* bug(ClipboardCopy): change children type to string (#9743)

* bug(ClipboardCopy): change children type to string

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* fix clipboardcopyexpanded to work with string children

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* refactor a bit

* fix bad rebase

---------

Signed-off-by: gitdallas <dallas.nicol@gmail.com>

* chore(deps): update devdependencies (#9817)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix Search Input - composable advanced search demo (#9484)

* Search Input - composable advanced search fix date

* remove isFill from datePicker

* docs(custom menu): add example with search input inline filtering (#9687)

* docs(custom menu): add example with search input inline filtering

* refactor(demo menu): rename to InlineSearchFilterMenuDemo

* chore(HelperText): update tests (#9761)

* chore(HelperText): update tests

* break out helpertextitem tests, update tests

* updates

* fix lint

* fix(Chip): update tooltip vis when chip updates (#9819)

* fix(Chip): enable tooltip when chip updates

* fix casting

* chore(DescriptionList): update tests (#9753)

* chore(DescriptionList): update tests

* break out tests, pr feedback

* updates

* add autofit width mod test

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.30
 - @patternfly/react-core@5.2.0-prerelease.30
 - @patternfly/react-docs@6.2.0-prerelease.30
 - demo-app-ts@5.1.1-prerelease.53
 - @patternfly/react-table@5.2.0-prerelease.30

* chore(TreeView): updated tests (#9773)

* chore(TreeView): updated tests

* Added tests for TreeViewListItem

* Added tests for TreeViewRoot and TreeView

* Updated snapshots and queries

* chore(Table) convert demos to ts (#9621)

* chore(table) convert to TS

chore(DashboardWrapper) convert to TS

chore(Table) convert demos to TS

delete superfluous dashboard components

declare as ts files

remove duplicate ids

fix import errors, WIP build errors

sync toolbar demo with main

* update import paths

* fix more import paths

* try import from dist/esm

* fix build

* convert remaining table demos to ts, WIP draggable logic

* revert col management with draggable to previous dnd implementation

* align file names with demo names, cleanup types, fix TS errors in demo files

* update fileNames in table.md

* PR feedback from Eric

* fix category dropdown

* fix demos, remove table actions that do not support main purpose of column management demos

* add fix for a11y tests as suggested by Eric

* update toolbar snap

* add param type to labelText

---------

Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.31
 - @patternfly/react-core@5.2.0-prerelease.31
 - @patternfly/react-docs@6.2.0-prerelease.31
 - demo-app-ts@5.1.1-prerelease.54
 - @patternfly/react-table@5.2.0-prerelease.31

* chore(deps): update devdependencies (#9829)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs(select): Adds documentation to React examples. (#9536)

* fix conflicts

* docs(select): Adds documentation for React examples.

* Adds content to new select React examples.

* Updates typeahead with create example.

* Clarify mult typeahead with create content.

* Finalizing wording.

* Updates content from review.

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.32
 - @patternfly/react-core@5.2.0-prerelease.32
 - @patternfly/react-docs@6.2.0-prerelease.32
 - demo-app-ts@5.1.1-prerelease.55
 - @patternfly/react-table@5.2.0-prerelease.32

* chore(deps): update devdependencies (#9833)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update devdependencies (#9837)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix link to patternfly community contributors document (#9840)

* chore(deps): update devdependencies (#9846)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(Table): make tooltip prop consistent (#9803)

* fix(Table): make tooltip prop consistent

* make tooltip ReactNode and add tooltipProps to Th

* add prop to useEffect

* fix logic for keyboard focus

* fix useeffect

* chore(DataList): convert data list react demo to TS (#9818)

* convert data list react demo to TS

* update function component name to match file

* fix(AlertGroupDemo): crashed when adding default alerts (#9826)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.33
 - @patternfly/react-core@5.2.0-prerelease.33
 - @patternfly/react-docs@6.2.0-prerelease.33
 - demo-app-ts@5.1.1-prerelease.56
 - @patternfly/react-table@5.2.0-prerelease.33

* chore(deps): update dependency @types/jest to v29.5.11 (#9854)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Popover returnFocusOnDeactivate prop (#9865)

Closes #9863

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.34
 - @patternfly/react-core@5.2.0-prerelease.34
 - @patternfly/react-docs@6.2.0-prerelease.34
 - demo-app-ts@5.1.1-prerelease.57
 - @patternfly/react-table@5.2.0-prerelease.34

* chore(deps): update dependency @patternfly/patternfly to v5.2.0-prerelease.7 (#9867)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.8
 - @patternfly/react-code-editor@5.2.0-prerelease.35
 - @patternfly/react-core@5.2.0-prerelease.35
 - @patternfly/react-docs@6.2.0-prerelease.35
 - @patternfly/react-icons@5.2.0-prerelease.9
 - demo-app-ts@5.1.1-prerelease.58
 - @patternfly/react-styles@5.2.0-prerelease.6
 - @patternfly/react-table@5.2.0-prerelease.35
 - @patternfly/react-tokens@5.2.0-prerelease.7

* chore(deps): update devdependencies (#9873)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(MenuItem): Add download to MenuItem (#9892)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.36
 - @patternfly/react-core@5.2.0-prerelease.36
 - @patternfly/react-docs@6.2.0-prerelease.36
 - @patternfly/react-integration@5.1.1-prerelease.16
 - demo-app-ts@5.1.1-prerelease.59
 - @patternfly/react-table@5.2.0-prerelease.36

* feat(Accordion): added toggle alignment functionality (#9877)

* feat(Accordion): added toggle alignment functionality

* Updated prop name and description

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.37
 - @patternfly/react-core@5.2.0-prerelease.37
 - @patternfly/react-docs@6.2.0-prerelease.37
 - demo-app-ts@5.1.1-prerelease.60
 - @patternfly/react-table@5.2.0-prerelease.37

* chore(deps): update devdependencies (#9885)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: add primary button with icon to button docs (#9871)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.38
 - @patternfly/react-core@5.2.0-prerelease.38
 - @patternfly/react-docs@6.2.0-prerelease.38
 - demo-app-ts@5.1.1-prerelease.61
 - @patternfly/react-table@5.2.0-prerelease.38

* fix(Chip): prevented duplicate ID being applied (#9886)

* fix(Chip): prevented duplicate ID being applied

* Updated snapshot

* Updated integration test selector

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.39
 - @patternfly/react-core@5.2.0-prerelease.39
 - @patternfly/react-docs@6.2.0-prerelease.39
 - @patternfly/react-integration@5.1.1-prerelease.17
 - demo-app-ts@5.1.1-prerelease.62
 - @patternfly/react-table@5.2.0-prerelease.39

* chore(expandablesection): Added a demo to show how to use expandable section to create an expandable text component. (#9887)

* chore(expandablesection): Added a demo to show how to use expandable section to create an expandable text component.

* Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md

Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>

* Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md

Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>

* Update packages/react-core/src/demos/ExpandableSection/ExpandableSection.md

Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>

---------

Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.40
 - @patternfly/react-core@5.2.0-prerelease.40
 - @patternfly/react-docs@6.2.0-prerelease.40
 - demo-app-ts@5.1.1-prerelease.63
 - @patternfly/react-table@5.2.0-prerelease.40

* feat(CodeEditor): use new monaco package (#9842)

* feat(CodeEditor): use new monaco package

* remove commented code

* fix integration

* update tests and mock out editor

* move to direct dependency

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.41
 - @patternfly/react-docs@6.2.0-prerelease.41
 - @patternfly/react-integration@5.1.1-prerelease.18

* feat(Modal next): Introduce a next composable Modal (#9852)

* feat(Modal next): Introduce a next composble Modal

* upodate for failing tests

* add integration test

* updates from review

* updates from Erin's comments

* Updates from comments

* chore(build): Fix lint issues (#9938)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.42
 - @patternfly/react-core@5.2.0-prerelease.41
 - @patternfly/react-docs@6.2.0-prerelease.42
 - @patternfly/react-integration@5.1.1-prerelease.19
 - demo-app-ts@5.1.1-prerelease.64
 - @patternfly/react-table@5.2.0-prerelease.41

* feat(DragDrop): new drag drop styling fixes (#9784)

* feat(DragDrop): introduce new package and deprecate old implementation

* refactor a bunch

* style fixes

* fix lint errors

* fix lint

* update snap

* update duallistselector example, try exporting interface from separate file

* bump versions in dragdrop for mismatch

* fix versions

* pr feedback

* fix versions after merge

* version update after rebase

* update md

* move into next folder for docgen

* update version after rebase

* update ver after rebase

* update ver after rebase

* update ver after rebase

* remove unused prop, update wording

* move some examples to demos

* update ver after rebase

* update new demos text

* update wording p1

* update wording p2

* update wording p3

* update wording p4

* fix links

* remove beta flags since page is beta

* update ver after rebase

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.43
 - @patternfly/react-core@5.2.0-prerelease.42
 - @patternfly/react-docs@6.2.0-prerelease.43
 - @patternfly/react-drag-drop@5.2.0-prerelease.0
 - demo-app-ts@5.1.1-prerelease.65
 - @patternfly/react-table@5.2.0-prerelease.42

* Add support for isLabelWrapped and component in Checkbox / Radio (#9830)

* feat(Checkbox): add support for isLabelWrapped and isLabelBeforeButton

* feat(Radio): add support for component

* refactor(Radio/Checkbox): check isLabelBeforeButton only once

* feat(Radio/Checkbox): add support for component === "label" behaving the same as isLabelWrapped

* docs(Radio/Checkbox): update props description

* test(Checkbox): add unit tests

* test(Checkbox): unit test

* test(Radio): unit tests

* chore(build): Fix lint errors (#9950)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.44
 - @patternfly/react-core@5.2.0-prerelease.43
 - @patternfly/react-docs@6.2.0-prerelease.44
 - @patternfly/react-drag-drop@5.2.0-prerelease.1
 - demo-app-ts@5.1.1-prerelease.66
 - @patternfly/react-table@5.2.0-prerelease.43

* chore(deps): update devdependencies (#9932)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(Popover): doc click event (#9952)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.45
 - @patternfly/react-core@5.2.0-prerelease.44
 - @patternfly/react-docs@6.2.0-prerelease.45
 - @patternfly/react-drag-drop@5.2.0-prerelease.2
 - demo-app-ts@5.1.1-prerelease.67
 - @patternfly/react-table@5.2.0-prerelease.44

* Update react-core dist/dynamic to include exported styles (#9939)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.9
 - @patternfly/react-code-editor@5.2.0-prerelease.46
 - @patternfly/react-core@5.2.0-prerelease.45
 - @patternfly/react-docs@6.2.0-prerelease.46
 - @patternfly/react-drag-drop@5.2.0-prerelease.3
 - @patternfly/react-icons@5.2.0-prerelease.10
 - demo-app-ts@5.1.1-prerelease.68
 - @patternfly/react-table@5.2.0-prerelease.45

* chore(deps): update devdependencies (#9955)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* FileUploadField fix to set name attribute on input element (#9941)

* FileUploadField name attribute fix

* update snapshots

* prevent breaking change

---------

Co-authored-by: nicolethoen <nthoen@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.47
 - @patternfly/react-core@5.2.0-prerelease.46
 - @patternfly/react-docs@6.2.0-prerelease.47
 - @patternfly/react-drag-drop@5.2.0-prerelease.4
 - demo-app-ts@5.1.1-prerelease.69
 - @patternfly/react-table@5.2.0-prerelease.46

* chore(deps): update devdependencies (#9967)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Victory dependencies (#9963)

* feat(charts): Victory dependency update

Closes #9960

* chore(charts): update lodash dependency

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.2.0-prerelease.10
 - @patternfly/react-docs@6.2.0-prerelease.48

* fix(Clipboard copy): Fixed regression with updating main content when expanded (#9975)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.48
 - @patternfly/react-core@5.2.0-prerelease.47
 - @patternfly/react-docs@6.2.0-prerelease.49
 - @patternfly/react-drag-drop@5.2.0-prerelease.5
 - demo-app-ts@5.1.1-prerelease.70
 - @patternfly/react-table@5.2.0-prerelease.47

* fix(ClipboardCopy): update main content on children change when expanded (#10015)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.49
 - @patternfly/react-core@5.2.0-prerelease.48
 - @patternfly/react-docs@6.2.0-prerelease.50
 - @patternfly/react-drag-drop@5.2.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.71
 - @patternfly/react-table@5.2.0-prerelease.48

* feat(DragDrop): fix import warning (#10023)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@6.2.0-prerelease.51
 - @patternfly/react-drag-drop@5.2.0-prerelease.7

* fix: prevent console warning in checkbox & radio (#10048)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.50
 - @patternfly/react-core@5.2.0-prerelease.49
 - @patternfly/react-docs@6.2.0-prerelease.52
 - @patternfly/react-drag-drop@5.2.0-prerelease.8
 - demo-app-ts@5.1.1-prerelease.72
 - @patternfly/react-table@5.2.0-prerelease.49

* chore(release): releasing packages [ci skip]

 - eslint-plugin-patternfly-react@5.2.0
 - @patternfly/react-charts@7.2.0
 - @patternfly/react-code-editor@5.2.0
 - @patternfly/react-core@5.2.0
 - @patternfly/react-docs@6.2.0
 - @patternfly/react-drag-drop@5.2.0
 - @patternfly/react-icons@5.2.0
 - @patternfly/react-styles@5.2.0
 - @patternfly/react-table@5.2.0
 - @patternfly/react-tokens@5.2.0

* chore(release): releasing packages [ci skip]

 - eslint-plugin-patternfly-react@5.3.0-prerelease.0
 - @patternfly/react-charts@7.3.0-prerelease.0
 - @patternfly/react-code-editor@5.3.0-prerelease.0
 - @patternfly/react-core@5.3.0-prerelease.0
 - @patternfly/react-docs@6.3.0-prerelease.0
 - @patternfly/react-drag-drop@5.3.0-prerelease.0
 - @patternfly/react-icons@5.3.0-prerelease.0
 - @patternfly/react-styles@5.3.0-prerelease.0
 - @patternfly/react-table@5.3.0-prerelease.0
 - @patternfly/react-tokens@5.3.0-prerelease.0

* Revert release attempt (#10062)

* Revert "chore(release): releasing packages [ci skip]"

This reverts commit 30b52a0.

* Revert "chore(release): releasing packages [ci skip]"

This reverts commit b2e8cc2.

* fix: version of eslint-plugin-patternfly-react

* chore: do promotion in two steps [ci skip]

* fix: white space change to trigger prerelease

* chore(release): releasing packages [ci skip]

 - eslint-plugin-patternfly-react@5.2.1-prerelease.0

* chore(build): add script to stop exporting demos in built files (#10063)

* chore(build): add script to stop exporting demos in built files

* chore(build): update to remove demo exports from shipped TS files also

* chore(ci): update deployment to clean exports of demos

* fix: whitespace change to trigger prerelease

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.2.0-prerelease.51
 - @patternfly/react-core@5.2.0-prerelease.50
 - @patternfly/react-docs@6.2.0-prerelease.53
 - @patternfly/react-drag-drop@5.2.0-prerelease.9
 - demo-app-ts@5.1.1-prerelease.73
 - @patternfly/react-table@5.2.0-prerelease.50

* chore: update promote script [ci skip]

* chore(release): releasing packages [ci skip]

 - eslint-plugin-patternfly-react@5.2.1
 - @patternfly/react-charts@7.2.0
 - @patternfly/react-code-editor@5.2.0
 - @patternfly/react-core@5.2.0
 - @patternfly/react-docs@6.2.0
 - @patternfly/react-drag-drop@5.2.0
 - @patternfly/react-icons@5.2.0
 - @patternfly/react-styles@5.2.0
 - @patternfly/react-table@5.2.0
 - @patternfly/react-tokens@5.2.0

* chore: prep repo for 5.3 development [ci skip]

* chore(release): releasing packages [ci skip]

 - eslint-plugin-patternfly-react@5.3.0-prerelease.0
 - @patternfly/react-charts@7.3.0-prerelease.0
 - @patternfly/react-code-editor@5.3.0-prerelease.0
 - @patternfly/react-core@5.3.0-prerelease.0
 - @patternfly/react-docs@6.3.0-prerelease.0
 - @patternfly/react-drag-drop@5.3.0-prerelease.0
 - @patternfly/react-icons@5.3.0-prerelease.0
 - @patternfly/react-styles@5.3.0-prerelease.0
 - @patternfly/react-table@5.3.0-prerelease.0
 - @patternfly/react-tokens@5.3.0-prerelease.0

* fix: demo-app version bump issue (#10072)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-integration@5.1.1-prerelease.20
 - demo-app-ts@5.1.1-prerelease.74

* fix(charts): adjust for Victory types changes (#10082)

Fixes #10078
Fixes #10064

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.3.0-prerelease.1
 - @patternfly/react-docs@6.3.0-prerelease.1

* feat(CodeEditor): pass additional props to monaco-editor, update readme (#10080)

* feat(CodeEditor): pass through additional props to Editor

* update readme

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.1
 - @patternfly/react-docs@6.3.0-prerelease.2

* feat(JumpLinks): support passing a reference to scroll element (#9961)

* feat(JumpLinks): support passing a reference to scroll HTMLElement

* docs(JumpLinks): update demo to show example with scrollableRef

* refactor(JumpLinks): getScrollableElement check if HTMLElement first

Co-authored-by: Christian Vogt <cvogt@redhat.com>

* docs(JumpLinks): mention scrollableRef as an option

---------

Co-authored-by: Christian Vogt <cvogt@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.2
 - @patternfly/react-core@5.3.0-prerelease.1
 - @patternfly/react-docs@6.3.0-prerelease.3
 - @patternfly/react-drag-drop@5.3.0-prerelease.1
 - demo-app-ts@5.1.1-prerelease.75
 - @patternfly/react-table@5.3.0-prerelease.1

* fix(Menu toggle): Passed aria label prop value to typeahead variant (#10084)

* fix(Menu toggle): Passed aria label prop value to typeahead variant

* Fix failing build. Add back default so it does not break consumers

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.3
 - @patternfly/react-core@5.3.0-prerelease.2
 - @patternfly/react-docs@6.3.0-prerelease.4
 - @patternfly/react-drag-drop@5.3.0-prerelease.2
 - demo-app-ts@5.1.1-prerelease.76
 - @patternfly/react-table@5.3.0-prerelease.2

* Revert "bug(ClipboardCopy): change children type to string (#9743)" (#9895)

This reverts commit a414253.

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.4
 - @patternfly/react-core@5.3.0-prerelease.3
 - @patternfly/react-docs@6.3.0-prerelease.5
 - @patternfly/react-drag-drop@5.3.0-prerelease.3
 - demo-app-ts@5.1.1-prerelease.77
 - @patternfly/react-table@5.3.0-prerelease.3

* feat(DualListSelector next): Add next composable Dual List Selector (#9901)

* create next environment

* updated all examples to be composable

* fix double VO for list controls

* remove obsolete example files

* rename examples

* use stronger types for unknowns

* remove business logic in main component

* fix tests

* fixed a11y failures

* update composability based on PR review

* rm unnecessary funct and update tests

* rm prop null assignment and add beta tag

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.5
 - @patternfly/react-core@5.3.0-prerelease.4
 - @patternfly/react-docs@6.3.0-prerelease.6
 - @patternfly/react-drag-drop@5.3.0-prerelease.4
 - demo-app-ts@5.1.1-prerelease.78
 - @patternfly/react-table@5.3.0-prerelease.4

* fix(Popper): check for undefined before accessing (#10086)

* chore(chars): Clean up chart examples (#10094)

#10093

* bug(Select): expose height and max height props for Menu content (#10075)

* bug(Select): expose height and max height props for Menu contnet

* add isScrollable prop

* Update packages/react-core/src/components/Select/Select.tsx

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

---------

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

* feat(SearchInput): Add ability to add id to input in SearchInput component (#9974)

* Add ability to add id to SearchInput

* Fix typo

* Update prop name and add tests

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.3.0-prerelease.2
 - @patternfly/react-code-editor@5.3.0-prerelease.6
 - @patternfly/react-core@5.3.0-prerelease.5
 - @patternfly/react-docs@6.3.0-prerelease.7
 - @patternfly/react-drag-drop@5.3.0-prerelease.5
 - demo-app-ts@5.1.1-prerelease.79
 - @patternfly/react-table@5.3.0-prerelease.5

* chore(DashboardWrapper,DashboardHeader): fix for table imports (#10114)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.7
 - @patternfly/react-core@5.3.0-prerelease.6
 - @patternfly/react-docs@6.3.0-prerelease.8
 - @patternfly/react-drag-drop@5.3.0-prerelease.6
 - demo-app-ts@5.1.1-prerelease.80
 - @patternfly/react-table@5.3.0-prerelease.6

* fix(deps): bump to latest core (#10116)

* chore(deps): bump to latest core

* fix(deps): update to latest promoted core version

* fix(deps): remove ^ from core version

---------

Co-authored-by: Austin Sullivan <ausulliv@redhat.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.3.0-prerelease.3
 - @patternfly/react-code-editor@5.3.0-prerelease.8
 - @patternfly/react-core@5.3.0-prerelease.7
 - @patternfly/react-docs@6.3.0-prerelease.9
 - @patternfly/react-drag-drop@5.3.0-prerelease.7
 - @patternfly/react-icons@5.3.0-prerelease.1
 - demo-app-ts@5.1.1-prerelease.81
 - @patternfly/react-styles@5.3.0-prerelease.1
 - @patternfly/react-table@5.3.0-prerelease.7
 - @patternfly/react-tokens@5.3.0-prerelease.1

* fix(charts) - ChartLegendTooltip.title has wrong type (#10129)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.3.0-prerelease.4
 - @patternfly/react-docs@6.3.0-prerelease.10

* fix(Select): focus first item when opened by click (#10125)

* fix(select): focus first item when opened by click

* fix(dropdown/menu/pagination): Update to focus first item on click

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.9
 - @patternfly/react-core@5.3.0-prerelease.8
 - @patternfly/react-docs@6.3.0-prerelease.11
 - @patternfly/react-drag-drop@5.3.0-prerelease.8
 - demo-app-ts@5.1.1-prerelease.82
 - @patternfly/react-table@5.3.0-prerelease.8

* fix(Menu): Fix crash in menu referencing invalid array index (#10153)

* Fix crash in menu

* Update code best on review feedback

* fix linting

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.10
 - @patternfly/react-core@5.3.0-prerelease.9
 - @patternfly/react-docs@6.3.0-prerelease.12
 - @patternfly/react-drag-drop@5.3.0-prerelease.9
 - demo-app-ts@5.1.1-prerelease.83
 - @patternfly/react-table@5.3.0-prerelease.9

* 🐛 Address datepicker crashing when manually entering year (#10134)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.11
 - @patternfly/react-core@5.3.0-prerelease.10
 - @patternfly/react-docs@6.3.0-prerelease.13
 - @patternfly/react-drag-drop@5.3.0-prerelease.10
 - demo-app-ts@5.1.1-prerelease.84
 - @patternfly/react-table@5.3.0-prerelease.10

* fix(Table): remove demos from package exports (#10165)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@6.3.0-prerelease.14
 - @patternfly/react-table@5.3.0-prerelease.11

* chore(Drag and drop): Marked old impmentation as deprecated (#10145)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.12
 - @patternfly/react-core@5.3.0-prerelease.11
 - @patternfly/react-docs@6.3.0-prerelease.15
 - @patternfly/react-drag-drop@5.3.0-prerelease.11
 - demo-app-ts@5.1.1-prerelease.85
 - @patternfly/react-table@5.3.0-prerelease.12

* chore(CI): reenable release dist caching (#10148)

* chore(deps): update dependency @patternfly/patternfly to v5.3.0-prerelease.4 (#10147)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.3.0-prerelease.5
 - @patternfly/react-code-editor@5.3.0-prerelease.13
 - @patternfly/react-core@5.3.0-prerelease.12
 - @patternfly/react-docs@6.3.0-prerelease.16
 - @patternfly/react-drag-drop@5.3.0-prerelease.12
 - @patternfly/react-icons@5.3.0-prerelease.2
 - demo-app-ts@5.1.1-prerelease.86
 - @patternfly/react-styles@5.3.0-prerelease.2
 - @patternfly/react-table@5.3.0-prerelease.13
 - @patternfly/react-tokens@5.3.0-prerelease.2

* fix(docs): fix undefined dashboard wrapper error in demos (#10191)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.14
 - @patternfly/react-core@5.3.0-prerelease.13
 - @patternfly/react-docs@6.3.0-prerelease.17
 - @patternfly/react-drag-drop@5.3.0-prerelease.13
 - demo-app-ts@5.1.1-prerelease.87
 - @patternfly/react-table@5.3.0-prerelease.14

* chore(react-code-editor): add missing `monaco-editor` dependency (#10198)

Signed-off-by: Jon Koops <jonkoops@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.15
 - @patternfly/react-docs@6.3.0-prerelease.18

* chore(deps): update dependency @patternfly/patternfly to v5.3.0-prerelease.5 (#10200)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(ClipboardCopy): warn when clipboard API is unavailable (#10186)

* bug(Select): Remove checkbox from no results found option (#10163)

* fix(Table): updated a11y for empty/nontext Th components (#10152)

* fix(Table): updated a11y for empty/nontext Th components

* Updated additional examples and demos

* Added initial Th test file

* Updated deprecated snapshots, removed outdated integration test

* fix(Table): added ActionsColumn prop to control close on click (#10179)

* fix(Table): added ActionsColumn prop to control close on click

* Added prop to prevent onOpenChange from being called

* fix(TableSortableResponsive demo): end page number (#10170)

* fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior (#10066)

* fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior

* revamp toggle click for checkbox

* chore(release): releasing packages [ci skip]

 - @patternfly/react-charts@7.3.0-prerelease.6
 - @patternfly/react-code-editor@5.3.0-prerelease.16
 - @patternfly/react-core@5.3.0-prerelease.14
 - @patternfly/react-docs@6.3.0-prerelease.19
 - @patternfly/react-drag-drop@5.3.0-prerelease.14
 - @patternfly/react-icons@5.3.0-prerelease.3
 - @patternfly/react-integration@5.1.1-prerelease.21
 - demo-app-ts@5.1.1-prerelease.88
 - @patternfly/react-styles@5.3.0-prerelease.3
 - @patternfly/react-table@5.3.0-prerelease.15
 - @patternfly/react-tokens@5.3.0-prerelease.3

* chore: simplify Babel configuration (#10189)

Signed-off-by: Jon Koops <jonkoops@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@6.3.0-prerelease.20

* fix(misc): demos not working due to variables not defined (#10169)

* fix(Tabs): broken demos

* fix(Banner): broken demo

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.17
 - @patternfly/react-core@5.3.0-prerelease.15
 - @patternfly/react-docs@6.3.0-prerelease.21
 - @patternfly/react-drag-drop@5.3.0-prerelease.15
 - demo-app-ts@5.1.1-prerelease.89
 - @patternfly/react-table@5.3.0-prerelease.16

* feat(Dropdown): Added support for setting height for dropdown (#10149)

* feat(Dropdown): Added support for setting height for dropdown

* apply isScrollable to menu if maxMenuHeight or menuHeight is defined

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.18
 - @patternfly/react-core@5.3.0-prerelease.16
 - @patternfly/react-docs@6.3.0-prerelease.22
 - @patternfly/react-drag-drop@5.3.0-prerelease.16
 - demo-app-ts@5.1.1-prerelease.90
 - @patternfly/react-table@5.3.0-prerelease.17

* fix(GenerateId): add randomness to id generator to prevent id collisions (#10178)

* fix(GenerateId): add randomness to id generator to prevent id collisions

* chore(docs): Correct prop description

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.19
 - @patternfly/react-core@5.3.0-prerelease.17
 - @patternfly/react-docs@6.3.0-prerelease.23
 - @patternfly/react-drag-drop@5.3.0-prerelease.17
 - demo-app-ts@5.1.1-prerelease.91
 - @patternfly/react-table@5.3.0-prerelease.18

* feat(templates): add templates package (#10110)

* feat(templates): add templates package

* revert v6 merge change from previous branch loc

* update template location to tab

* update ver after rebase

* add descriptions to simple select

* pr feedback

* fix merge

* update docs-framework and code-editor

* fix jest mocks

* back out codeeditor changes

* update templates version

* update templates version

* pr updates

* yarn lockfile

* update options type

* Revert "yarn lockfile"

This reverts commit 6839ce2.

* lockfile revert

* update ver

* update type

* doc build try 1

* feat(MenuToggle/Select): add status (#10209)

* feat(MenuToggle/Select): add status

* pr feedback

* update menutoggle example

* update example desc

* mark prop as beta

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.20
 - @patternfly/react-core@5.3.0-prerelease.18
 - @patternfly/react-docs@6.3.0-prerelease.24
 - @patternfly/react-drag-drop@5.3.0-prerelease.18
 - demo-app-ts@5.1.1-prerelease.92
 - @patternfly/react-table@5.3.0-prerelease.19
 - @patternfly/react-templates@1.0.0-prerelease.0

* fix(TextArea): remove invalid `onFocus` and `onBlur` props (#10193)

Closes #10192

Signed-off-by: Jon Koops <jonkoops@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.21
 - @patternfly/react-core@5.3.0-prerelease.19
 - @patternfly/react-docs@6.3.0-prerelease.25
 - @patternfly/react-drag-drop@5.3.0-prerelease.19
 - demo-app-ts@5.1.1-prerelease.93
 - @patternfly/react-table@5.3.0-prerelease.20
 - @patternfly/react-templates@1.0.0-prerelease.1

* fix(Card): updated v5 logic to prevent unclickable cards (#10202)

* fix(Card): updated v5 logic to prevent unclickable cards

* Updated API to have isSelected control selectable card state

* Updated cypress test

* Updated cypress test

* Updated cypress test

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.22
 - @patternfly/react-core@5.3.0-prerelease.20
 - @patternfly/react-docs@6.3.0-prerelease.26
 - @patternfly/react-drag-drop@5.3.0-prerelease.20
 - @patternfly/react-integration@5.1.1-prerelease.22
 - demo-app-ts@5.1.1-prerelease.94
 - @patternfly/react-table@5.3.0-prerelease.21
 - @patternfly/react-templates@1.0.0-prerelease.2

* Convert right-to-left demo to TS (#10164)

* covert RTL demo to TS

* update component type jsx to tsx

* update type js to ts

* fix doc build job

* implement review comments

* fix types

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.23
 - @patternfly/react-core@5.3.0-prerelease.21
 - @patternfly/react-docs@6.3.0-prerelease.27
 - @patternfly/react-drag-drop@5.3.0-prerelease.21
 - demo-app-ts@5.1.1-prerelease.95
 - @patternfly/react-table@5.3.0-prerelease.22
 - @patternfly/react-templates@1.0.0-prerelease.3

* feat(Select): add checkbox variant of the simple select template (#10159)

* feat(Select): add checkbox variant of the simple select template

* chore(Select): rename template

* fix(Select): mock generated id in CheckboxSelect snapshot tests

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@6.3.0-prerelease.28
 - @patternfly/react-templates@1.0.0-prerelease.4

* chore(Table): added more arialabeling for empty/nontext Table headers (#10205)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-docs@6.3.0-prerelease.29
 - @patternfly/react-table@5.3.0-prerelease.23

* feat(Label): allow clickable labels to be disabled (#10199)

* refactor(Label): rename button to closeButton

* feat(Label): allow clickable labels to be disabled

* docs(Label): add examples of clickable disabled

* refactor(Label): use style token for pf-m-disabled

* Prevented anchor onClick firing for AT

---------

Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.24
 - @patternfly/react-core@5.3.0-prerelease.22
 - @patternfly/react-docs@6.3.0-prerelease.30
 - @patternfly/react-drag-drop@5.3.0-prerelease.22
 - demo-app-ts@5.1.1-prerelease.96
 - @patternfly/react-table@5.3.0-prerelease.24
 - @patternfly/react-templates@1.0.0-prerelease.5

* fix(GenerateId): revert default behavior change (#10232)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.25
 - @patternfly/react-core@5.3.0-prerelease.23
 - @patternfly/react-docs@6.3.0-prerelease.31
 - @patternfly/react-drag-drop@5.3.0-prerelease.23
 - demo-app-ts@5.1.1-prerelease.97
 - @patternfly/react-table@5.3.0-prerelease.25
 - @patternfly/react-templates@1.0.0-prerelease.6

* chore: Create PF6_alpha_bug_request.md [ci skip]

* feat(MenuToggle): allow split action toggle text (#10256)

* feat(MenuToggle): allow split action toggle text

* use var

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.26
 - @patternfly/react-core@5.3.0-prerelease.24
 - @patternfly/react-docs@6.3.0-prerelease.32
 - @patternfly/react-drag-drop@5.3.0-prerelease.24
 - demo-app-ts@5.1.1-prerelease.98
 - @patternfly/react-table@5.3.0-prerelease.26
 - @patternfly/react-templates@1.0.0-prerelease.7

* fix(deploy): Redeployed to npm

* Update README.md

* Update README.md

* chore(release): releasing packages [ci skip]

 - @patternfly/react-code-editor@5.3.0-prerelease.27
 - @patternfly/react-core@5.3.0-prerelease.25
 - @patternfly/react-docs@6.3.0-prerelease.33
 - @patternfly/react-drag-drop@5.3.0-prerelease.25
 - demo-app-ts@5.1.1-prerelease.99
 - @patternfly/react-table@5.3.0-prerelease.27
 - @patternfly/react-templates@1.0.0-prerelease.8

* update jest config

* update template version

* update snapshots

* update failing snapshot

* update framework version

* address review comment

* update snapshots

---------

Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Jeff Puzzo <96431149+jpuzz0@users.noreply.github.com>
Co-authored-by: adamviktora <84135613+adamviktora@users.noreply.github.com>
Co-authored-by: Mark Franceschelli <39063664+mfrances17@users.noreply.github.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Austin Sullivan <ausulliv@redhat.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kells512 <72694484+Kells512@users.noreply.github.com>
Co-authored-by: nicolethoen <nthoen@redhat.com>
Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
Co-authored-by: Dallas <dallas.nicol@gmail.com>
Co-authored-by: Maria <mariaaga@redhat.com>
Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Yurith Rubio <78481690+yurith-rubio@users.noreply.github.com>
Co-authored-by: Joachim Schuler <jdh.schuler@gmail.com>
Co-authored-by: Robb Hamilton <rhamilto@redhat.com>
Co-authored-by: Donald Labaj <donald.labaj@gmail.com>
Co-authored-by: Vojtech Szocs <vszocs@redhat.com>
Co-authored-by: James Talton <talton@gmail.com>
Co-authored-by: Dan Labrecque <dlabrecq@redhat.com>
Co-authored-by: Christian Vogt <cvogt@redhat.com>
Co-authored-by: Jessie <jhuff@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
Co-authored-by: Jon Koops <jonkoops@gmail.com>
Co-authored-by: Ajay Pratap <ajay.pratap233@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants