Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert DashboardHeader and DashboardWrapper to TS #9544

Closed
2 tasks done
jenny-s51 opened this issue Aug 28, 2023 · 1 comment
Closed
2 tasks done

Convert DashboardHeader and DashboardWrapper to TS #9544

jenny-s51 opened this issue Aug 28, 2023 · 1 comment

Comments

@jenny-s51
Copy link
Contributor

jenny-s51 commented Aug 28, 2023 •
edited by Dominik-Petrik
Loading

Describe the enhancement or change
There are build issues caused by these jsx files when using them with TS demos.

The DashboardWrapper import is currently causing the build to fail in #9359 if the filetype is declared as ts and build issues were also seen in #9487 when trying to declare the demo as a ts file.

Any other information?
This was discovered through work on the #9367 epic

Tasks
Beta Give feedback
  1. Convert DashboardHeader to TS #9553
    Dominik-Petrik jenny-s51
  2. Convert DashboardWrapper to TS #9617
    Dominik-Petrik
@jenny-s51 jenny-s51 added the DevX label Aug 28, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 28, 2023
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Needs info in PatternFly Issues Aug 29, 2023
@jenny-s51 jenny-s51 mentioned this issue Sep 18, 2023
Merged
adamviktora added a commit to adamviktora/patternfly-react that referenced this issue Sep 20, 2023
@adamviktora
fix(Nav demo): update JS shortcuts to TS
39dae6a 
warnings should disappear once issue patternfly#9544 is closed
@wise-king-sullyman
Copy link
Contributor

Closing as all tasks are complete.

@github-project-automation github-project-automation bot moved this from Needs info to Done in PatternFly Issues Oct 10, 2023
adamviktora added a commit to adamviktora/patternfly-react that referenced this issue Oct 11, 2023
@adamviktora
fix(Nav demo): update JS shortcuts to TS
7685755 
warnings should disappear once issue patternfly#9544 is closed
jenny-s51 pushed a commit that referenced this issue Oct 19, 2023
@adamviktora
chore(Nav): convert demos to TS (#9487)
1194a7e 
* chore(Nav): convert demos to TS

* fix(Nav): omit <boolean> in useState

* fix(Nav): subnav aria-label

* chore(Nav): rename components

* chore(Nav): add preventDefault prop to NavItem components in demos

* refactor(Nav examples): simplify Array.apply, renaming

* fix(Nav demo): update JS shortcuts to TS

warnings should disappear once issue #9544 is closed

* docs(Nav): fix Flyout nav demo: hide sidebar bug

* chore(Nav demo): update DashboardHeader/Wrapper imports

* chore(Nav demo): use JS shortcut, since docs build still failing on ts

* refactor(Nav demo): get rid of Array.apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wise-king-sullyman @jenny-s51