Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description list basic demo #10184

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Add description list basic demo #10184

merged 6 commits into from
Jun 6, 2024

Conversation

ajaypratap003
Copy link
Member

What: Closes #7000
Add description list basic demo

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 21, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10184.surge.sh

A11y report: https://patternfly-react-pr-10184-a11y.surge.sh

kmcfaul
kmcfaul reviewed Mar 25, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@tlabaj tlabaj requested review from a team, mattnolting and mmenestr and removed request for a team April 17, 2024 13:51
wise-king-sullyman
wise-king-sullyman reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the content here is pretty different from the content of the core demo, is that something we're concerned with on these @tlabaj ?

thatblindgeye
thatblindgeye reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more nits below but otherwise looking good to me

packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx Outdated Show resolved Hide resolved
packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx Outdated Show resolved Hide resolved
@tlabaj
Copy link
Contributor

tlabaj commented Apr 26, 2024

It looks like the content here is pretty different from the content of the core demo, is that something we're concerned with on these @tlabaj ?

I agree with Austin, the content should match core as closely as possible. Could we update the data in the card to more closely align wit core please.

wise-king-sullyman
wise-king-sullyman requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's still some items that aren't lining up with the core demo, for instance the divider not going all the way across the card, the distance between the divider and the heading, the layout and order of the items, and the status being a link:

image

@kmcfaul
Copy link
Contributor

kmcfaul commented May 8, 2024

Still seeing the divider mismatch on the latest surge.

@ajaypratap003
Copy link
Member Author

Still seeing the divider mismatch on the latest surge.

@kmcfaul @wise-king-sullyman On local changes look fine but seems changes are not reflecting on surge.

image

wise-king-sullyman
wise-king-sullyman approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I see that same thing, not sure why

@ajaypratap003
Copy link
Member Author

Still seeing the divider mismatch on the latest surge.

Seems changes are not reflecting on surge. Please check it on local. It seems fine on local.

mattnolting
mattnolting reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! We need to get the previews working to confirm.

@nicolethoen nicolethoen force-pushed the demo-descriptionlist branch from 2834643 to dc49a75 Compare May 28, 2024 14:07
@nicolethoen
Copy link
Contributor

@mattnolting I think the preview is fixed if you wouldn't mind a quick CSS review

mattnolting
mattnolting approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work! LGTM 🤖

@nicolethoen nicolethoen merged commit 07cf3d4 into patternfly:main Jun 6, 2024
13 checks passed
tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jun 17, 2024
@ajaypratap003 @tlabaj
Add description list basic demo (patternfly#10184)
31d22c7 
* add description list basic demo

* fix DashboardWrapper not found issue

* implement review comments

* add divider and size

* update content

* fixed layout issues
tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jun 17, 2024
@ajaypratap003 @tlabaj
Add description list basic demo (patternfly#10184)
a8905d1 
* add description list basic demo

* fix DashboardWrapper not found issue

* implement review comments

* add divider and size

* update content

* fixed layout issues
tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jun 24, 2024
@ajaypratap003 @tlabaj
Add description list basic demo (patternfly#10184)
d539777 
* add description list basic demo

* fix DashboardWrapper not found issue

* implement review comments

* add divider and size

* update content

* fixed layout issues
tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jun 25, 2024
@ajaypratap003 @tlabaj
Add description list basic demo (patternfly#10184)
6dc67a5 
* add description list basic demo

* fix DashboardWrapper not found issue

* implement review comments

* add divider and size

* update content

* fixed layout issues
gitdallas pushed a commit that referenced this pull request Jun 25, 2024
@tlabaj @adamviktora
@edonehoo @ajaypratap003 @wise-king-sullyman @kmcfaul @Dominik-Petrik
Cherry pick main to v6 (#10619)
9e7b462 
* docs(Page): add example showing different type prop variants (#10352)

* docs(Page): add example showing different type prop variants

* docs(Page): make text color white in "subnav" section

* docs(Page): rename IDs in example

* docs(Table): update column management example to use link button for Cancel action (#10459)

* feat(Modal): support ReactNode type for 'title' prop

* fix(DatePicker/CalendarMonth): better range styling when some dates are disabled (#10398)

* fix(DatePicker/CalendarMonth): range styling when disabled dates

* chore(Datepicker): getElementSelectorToFocus function description

* feat(MenuToggle): add OUIA support

* docs(menu-toggle): Adds docs for split button examples. (#10268)

* docs(menu-toggle): Adds docs for split button examples.

* Update names of split toggle examples.

* Add description list basic demo (#10184)

* add description list basic demo

* fix DashboardWrapper not found issue

* implement review comments

* add divider and size

* update content

* fixed layout issues

* Convert demo application to Vite

* Upgrade Testing Library dependencies to latest version

* upgrade  to latest version

* upgrade  to latest version

* upgrade  to latest version

* chore(deps): replace camel-case with change-case

* Masthead: add demo that includes horizontal nav

* chore: use  protocol for workspace dependencies

* chore(deps): upgrade  to the latest version

* chore(deps): upgrade  to the latest version

* chore(deps): upgrade  to the latest version

* chore(deps): remove unused  dependency

* chore(deps): upgrade  to the latest version

* chore(deps): ugprade Jest to latest version

* chore(deps): upgrade  to the latest version

* chore(deps): upgrade  dependencies to the latest version

* chore(deps): upgrade  to the latest version

* chore(deps): update dependencies

* update yarn file

* more deps fixes

* more deps

* fix(build): get our custom TS transformers working again (#10477)

* fix(build): get our custom TS transformers working again

* chore(deps): Update lock file

* Update lock file

* chore(deps): Update yarn lock

* fix demo app

* cherry pick yarn changes

* update yarn.lock

* updatw snapshots

* fix demo app

* feat(templates): toggle props & improvements (#10473)

* feat(templates): toggle props & improvements

* remove toggleContent from typeahead template

* update template names

* update tests

* added SimpleSelect tests

* fix yarnlock

* fix(CodeEditor) support Mac and PC shortcuts in example (#10472)

* updatee lock file

---------

Co-authored-by: adamviktora <84135613+adamviktora@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Ajay Pratap <ajay.pratap233@gmail.com>
Co-authored-by: Austin Sullivan <ausulliv@redhat.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@mattnolting mattnolting mattnolting approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

@mmenestr mmenestr Awaiting requested review from mmenestr mmenestr was automatically assigned from patternfly/ux-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description list basic demo
8 participants
@ajaypratap003 @patternfly-build @tlabaj @kmcfaul @nicolethoen @mattnolting @wise-king-sullyman @thatblindgeye