-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rebase): rebase 6v branch" #10272
Conversation
- @patternfly/react-code-editor@5.2.0-prerelease.20 - @patternfly/react-core@5.2.0-prerelease.20 - @patternfly/react-docs@6.2.0-prerelease.20 - demo-app-ts@5.1.1-prerelease.43 - @patternfly/react-table@5.2.0-prerelease.20
* fix(Text input): Added aria-expanded * add interface * updates from review
…rawer item read state (patternfly#9569) * fix(Notification Drawer): Added screen reader text for notification drawer item read state * fix snapshot * Update prop description * add aria-live * update snapshots
…y#9709) * feat: ability to add props to WizardFooter buttons * fix(WizardFooter): null check * fix(Wizard): simpler design of adding footer buttons props * test(Wizard): can add props to footer buttons * docs(WizardFooter): move comment so docs have correct description * refactor(WizardFooter): move FooterButtonProps to types file
* chore(Divider): update tests to new standards * changes from PR review
- @patternfly/react-code-editor@5.2.0-prerelease.21 - @patternfly/react-core@5.2.0-prerelease.21 - @patternfly/react-docs@6.2.0-prerelease.21 - demo-app-ts@5.1.1-prerelease.44 - @patternfly/react-table@5.2.0-prerelease.21
…es (patternfly#9347) * bug(build): fixed built ESM files importing CJS files from react-styles * edited yarn.lock to invalidate deps cache in GH actions * excluded file extensions from react-styles path transform in ESM build * updated jest config to transform .mjs files * updated pr action to invalidate deps cache if package files added/edited * chore(deps): Add ts-node to support executing typescript files directly
- @patternfly/react-code-editor@5.2.0-prerelease.22 - @patternfly/react-core@5.2.0-prerelease.22 - @patternfly/react-docs@6.2.0-prerelease.22 - demo-app-ts@5.1.1-prerelease.45 - @patternfly/react-table@5.2.0-prerelease.22 - transformer-react-styles-esm-imports@1.0.1-prerelease.0
…lease.4 (patternfly#9780) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/react-charts@7.2.0-prerelease.6 - @patternfly/react-code-editor@5.2.0-prerelease.23 - @patternfly/react-core@5.2.0-prerelease.23 - @patternfly/react-docs@6.2.0-prerelease.23 - @patternfly/react-icons@5.2.0-prerelease.6 - demo-app-ts@5.1.1-prerelease.46 - @patternfly/react-styles@5.2.0-prerelease.4 - @patternfly/react-table@5.2.0-prerelease.23 - @patternfly/react-tokens@5.2.0-prerelease.5
…ly#9048 (patternfly#9087) * feat(Datalist): implement full page Basic demo to match HTML patternfly#9048 * fix syntax error * comments applied * comments applied * comments applied * comments applied * \xa0 comments applied * move key per review comments * address PR comments * revert change to package.json * Converted basic demo to TS --------- Co-authored-by: nicolethoen <nthoen@redhat.com> Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
- @patternfly/react-code-editor@5.2.0-prerelease.24 - @patternfly/react-core@5.2.0-prerelease.24 - @patternfly/react-docs@6.2.0-prerelease.24 - demo-app-ts@5.1.1-prerelease.47 - @patternfly/react-table@5.2.0-prerelease.24
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lease.5 (patternfly#9806) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/react-charts@7.2.0-prerelease.7 - @patternfly/react-code-editor@5.2.0-prerelease.25 - @patternfly/react-core@5.2.0-prerelease.25 - @patternfly/react-docs@6.2.0-prerelease.25 - @patternfly/react-icons@5.2.0-prerelease.7 - demo-app-ts@5.1.1-prerelease.48 - @patternfly/react-styles@5.2.0-prerelease.5 - @patternfly/react-table@5.2.0-prerelease.25 - @patternfly/react-tokens@5.2.0-prerelease.6
- @patternfly/react-code-editor@5.2.0-prerelease.26 - @patternfly/react-core@5.2.0-prerelease.26 - @patternfly/react-docs@6.2.0-prerelease.26 - demo-app-ts@5.1.1-prerelease.49 - @patternfly/react-table@5.2.0-prerelease.26
- @patternfly/react-code-editor@5.2.0-prerelease.27 - @patternfly/react-core@5.2.0-prerelease.27 - @patternfly/react-docs@6.2.0-prerelease.27 - demo-app-ts@5.1.1-prerelease.50 - @patternfly/react-table@5.2.0-prerelease.27
* clean up instances of Array.apply * rename item to value
- @patternfly/react-code-editor@5.2.0-prerelease.28 - @patternfly/react-core@5.2.0-prerelease.28 - @patternfly/react-docs@6.2.0-prerelease.28 - @patternfly/react-integration@5.1.1-prerelease.15 - demo-app-ts@5.1.1-prerelease.51 - @patternfly/react-table@5.2.0-prerelease.28
- @patternfly/react-code-editor@5.2.0-prerelease.29 - @patternfly/react-core@5.2.0-prerelease.29 - @patternfly/react-docs@6.2.0-prerelease.29 - @patternfly/react-icons@5.2.0-prerelease.8 - demo-app-ts@5.1.1-prerelease.52 - @patternfly/react-table@5.2.0-prerelease.29
* add spread prop test, update test * chore(DataList): update tests * fix merge error * break out into separate files, pr feedback * updates * fix some example ids * minor test updates * revert action change
* bug(ClipboardCopy): change children type to string Signed-off-by: gitdallas <dallas.nicol@gmail.com> * fix clipboardcopyexpanded to work with string children Signed-off-by: gitdallas <dallas.nicol@gmail.com> * refactor a bit * fix bad rebase --------- Signed-off-by: gitdallas <dallas.nicol@gmail.com>
* refactor(Label): rename button to closeButton * feat(Label): allow clickable labels to be disabled * docs(Label): add examples of clickable disabled * refactor(Label): use style token for pf-m-disabled * Prevented anchor onClick firing for AT --------- Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
- @patternfly/react-code-editor@5.3.0-prerelease.24 - @patternfly/react-core@5.3.0-prerelease.22 - @patternfly/react-docs@6.3.0-prerelease.30 - @patternfly/react-drag-drop@5.3.0-prerelease.22 - demo-app-ts@5.1.1-prerelease.96 - @patternfly/react-table@5.3.0-prerelease.24 - @patternfly/react-templates@1.0.0-prerelease.5
- @patternfly/react-code-editor@5.3.0-prerelease.25 - @patternfly/react-core@5.3.0-prerelease.23 - @patternfly/react-docs@6.3.0-prerelease.31 - @patternfly/react-drag-drop@5.3.0-prerelease.23 - demo-app-ts@5.1.1-prerelease.97 - @patternfly/react-table@5.3.0-prerelease.25 - @patternfly/react-templates@1.0.0-prerelease.6
* feat(MenuToggle): allow split action toggle text * use var
- @patternfly/react-code-editor@5.3.0-prerelease.26 - @patternfly/react-core@5.3.0-prerelease.24 - @patternfly/react-docs@6.3.0-prerelease.32 - @patternfly/react-drag-drop@5.3.0-prerelease.24 - demo-app-ts@5.1.1-prerelease.98 - @patternfly/react-table@5.3.0-prerelease.26 - @patternfly/react-templates@1.0.0-prerelease.7
- @patternfly/react-code-editor@5.3.0-prerelease.27 - @patternfly/react-core@5.3.0-prerelease.25 - @patternfly/react-docs@6.3.0-prerelease.33 - @patternfly/react-drag-drop@5.3.0-prerelease.25 - demo-app-ts@5.1.1-prerelease.99 - @patternfly/react-table@5.3.0-prerelease.27 - @patternfly/react-templates@1.0.0-prerelease.8
Preview: https://patternfly-react-pr-10272.surge.sh A11y report: https://patternfly-react-pr-10272-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed a TODO in the code that we can probably address
packages/react-table/src/components/Table/examples/TableNestedStickyHeader.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What: Closes #10261
Additional issues: