fix(charts): tooltip whitespace is not preserved for Safari #10355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10355.surge.sh A11y report: https://patternfly-react-pr-10355-a11y.surge.sh |
gitdallas
approved these changes
May 13, 2024
| @@ -157,7 +157,7 @@ export const getLegendTooltipSize = ({ | |||
| // Get spacing to help align legend labels and text values | |||
| const spacer = 'x'; | |||
| const getSpacing = (legendLabel: string, textLabel: string) => { | |||
| let spacing = ''; | |||
| let spacing = '\u00A0'; | |||
There was a problem hiding this comment.
just a note that this is a non-breaking space
There was a problem hiding this comment.
Yes, that's what I want. Cannot use here as the tooltip is also SVG.
tlabaj
approved these changes
May 14, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve tooltip whitespace for Safari
Closes #10354