Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Pagination): add offset example #9232

Merged
merged 1 commit into from
Aug 7, 2023
Merged

feat(Pagination): add offset example #9232

merged 1 commit into from
Aug 7, 2023

Conversation

MariaAga
Copy link
Contributor

@MariaAga MariaAga commented Jun 2, 2023

What: Closes #9231
when having a per_page=20, and offset is 20 (skip the first 20 items ,show item numbers 21,22,23...), page should be calculated to 2, but before this change it was calculated as 1

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 2, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9232.surge.sh

A11y report: https://patternfly-react-pr-9232-a11y.surge.sh

@MariaAga MariaAga force-pushed the pagination-offset-example branch from f33caba to 1f71338 Compare June 5, 2023 09:56
gitdallas
gitdallas requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the typo below

packages/react-core/src/components/Pagination/examples/Pagination.md Outdated Show resolved Hide resolved
@MariaAga MariaAga force-pushed the pagination-offset-example branch from 1f71338 to 54e0229 Compare June 6, 2023 08:28
@MariaAga
Copy link
Contributor Author

MariaAga commented Jun 6, 2023

The change in Pagination.tsx might be a breaking change, but offset didn't work as expected before it, should this pr be marked somehow?

@nicolethoen nicolethoen requested a review from tlabaj June 6, 2023 19:48
@tlabaj tlabaj requested a review from mcarrano June 12, 2023 19:01
mcarrano
mcarrano reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will defer to others. I'm not really sure what this example is intended to illustrate, but seems to function as expected.

@tlabaj tlabaj merged commit 286bf8c into patternfly:main Aug 7, 2023
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
@MariaAga @nicolethoen
feat(Pagination): add offset example (patternfly#9232)
b4b49bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarrano mcarrano mcarrano left review comments

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@tlabaj tlabaj tlabaj approved these changes

@gitdallas gitdallas gitdallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination - add offset example
6 participants
@MariaAga @patternfly-build @gitdallas @mcarrano @tlabaj @thatblindgeye