Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Modal): use css vars to set width, add maxWidth #9300

Merged
merged 4 commits into from
Aug 1, 2023
Merged

feat(Modal): use css vars to set width, add maxWidth #9300

merged 4 commits into from
Aug 1, 2023

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jun 22, 2023

What: Closes #8351

Adds maxWidth property.
Updates width and maxWidth to be set via css variables instead of directly as a style property.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 22, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9300.surge.sh

A11y report: https://patternfly-react-pr-9300-a11y.surge.sh

tlabaj
tlabaj requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write unit test to verify these are being applied correctly?

packages/react-core/src/components/Modal/ModalContent.tsx Show resolved Hide resolved
@kmcfaul kmcfaul changed the base branch from main to postV5 July 18, 2023 13:37
@tlabaj tlabaj requested a review from mcoker July 18, 2023 15:02
mcoker
mcoker approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@kmcfaul kmcfaul changed the base branch from postV5 to main July 31, 2023 17:56
@tlabaj tlabaj merged commit fed8205 into patternfly:main Aug 1, 2023
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
@kmcfaul @nicolethoen
feat(Modal): use css vars to set width, add maxWidth (patternfly#9300)
056617a 
* feat(Modal): use css vars to set width, add maxWidth

* account for number input

* updated for css width

* fix space in expected value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@tlabaj tlabaj tlabaj approved these changes

@mcoker mcoker mcoker approved these changes

@jenny-s51 jenny-s51 jenny-s51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal - width and max-width can be set via CSS vars
6 participants
@kmcfaul @patternfly-build @jenny-s51 @mcoker @tlabaj @thatblindgeye