Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(a11y): clean up a11y config so we test valid URLs and limit timeouts #9328

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

nicolethoen
Copy link
Contributor

Closes #9327

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 3, 2023

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a11y tests running as expected. Just wondering if we need the console.log or if it can be removed

packages/react-docs/patternfly-a11y.config.js Outdated Show resolved Hide resolved
@nicolethoen nicolethoen requested a review from tlabaj August 4, 2023 20:02
@tlabaj tlabaj merged commit ebfafc4 into patternfly:main Aug 14, 2023
nicolethoen added a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
…eouts (patternfly#9328)

* chore(a11y): clean up a11y config so we test valid URLs and limit timeouts

* tighten logic a little more

* remove console statement

* use logical OR rather than bitwise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y tests hitting incorrect urls causing timeouts
6 participants