Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Drawer): add noBackground to colorVariant #9372

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jul 18, 2023

What: Closes #8548

Adds no-background to colorVariant props in Drawer.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 18, 2023

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PrimaryDetailContentPadding.tsx file could also use an update to remove the hardcoded class

@kmcfaul kmcfaul changed the base branch from postV5 to main July 31, 2023 17:55
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tlabaj tlabaj merged commit 2567f3c into patternfly:main Aug 1, 2023
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
* feat(Drawer): add noBackground to colorVariant

* update missed hardcoded class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer - support for no/transparent background on drawer content, panel, and section
5 participants