-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Tabs): converted tabs & tables demo to use inputs for selection #9395
docs(Tabs): converted tabs & tables demo to use inputs for selection #9395
Conversation
Preview: https://patternfly-react-pr-9395.surge.sh A11y report: https://patternfly-react-pr-9395-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can we just make one additional fix on line ~257:
// Preventing default behavior for demo purposes only
<a onClick={(event) => event.preventDefault()} href="#">siemur/test-space</a>
Right now clicking those links causes the redirect which makes the first row become selected again, which may be confusing in the context of the demo (make it seem like the old behavior still exists or that a new "bug" was introduced)
590921b
to
811f30e
Compare
Followup to my previous comment after some discussion on Slack with Austin, we may want to have a larger discussion regarding how we handle links in examples/demos.
cc'ing @andrew-ronaldson for visibility |
…atternfly#9395) * docs(Tabs): converted tabs & tables demo to use inputs for selection * docs(Tabs): updated links to not refresh the page to prevent confusion
What: Closes #9100
Additional issues:
Convenience link to the changed demo: https://patternfly-react-pr-9395.surge.sh/components/tabs/react-demos/tables-and-tabs/