Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): focused items should scrollintoview when overflowed #9408

Merged
merged 5 commits into from
Aug 14, 2023
Merged

fix(Menu): focused items should scrollintoview when overflowed #9408

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ceef7a7
Rebase postv5 (#9393)
tlabaj Jul 21, 2023
3d650a6
fix(Menu): focused items should scrollintoview when overflowed
kmcfaul Jul 26, 2023
5e16975
fix merge error
kmcfaul Jul 31, 2023
0f57df6
fix merge snap
kmcfaul Jul 31, 2023
406f391
change scroll to auto
kmcfaul Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/react-core/src/components/Menu/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,23 @@ const MenuItemBase: React.FunctionComponent<MenuItemProps> = ({
setFlyoutRef(null);
}
};

React.useEffect(() => {
if (isFocused && ref.current) {
const itemEl = ref.current;
const parentListEl = itemEl.parentElement;

if (parentListEl) {
const isAboveTop = itemEl.offsetTop - parentListEl.offsetTop < parentListEl.scrollTop;
const isBelowBottom = itemEl.offsetTop - parentListEl.offsetTop + itemEl.clientHeight;

if (isAboveTop || isBelowBottom) {
itemEl.scrollIntoView({ behavior: 'auto', block: 'nearest' });
}
}
}
}, [isFocused]);

const isSelectMenu = menuRole === 'listbox';

const renderItem = (
Expand Down