Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): added ability to customize initial focus #9453

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Aug 4, 2023

What: Closes #4018

Modal custom focus example

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 4, 2023

@tlabaj tlabaj requested review from kmcfaul and nicolethoen August 8, 2023 12:36
@tlabaj tlabaj added the A11y label Aug 8, 2023
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Even the VO interaction is focusing on the correct button when the modal opens, and when it closes :)

@nicolethoen nicolethoen merged commit 4f4c1d0 into patternfly:main Aug 9, 2023
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
* feat(Modal): added ability to customize initial focus

* Added integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should modal component keyboard focus go directly to primary button?
5 participants