Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TreeView): onCollapse callback #9480

Merged
merged 3 commits into from
Aug 16, 2023
Merged

feat(TreeView): onCollapse callback #9480

merged 3 commits into from
Aug 16, 2023

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Aug 9, 2023

What: Closes #9361

Adds onCollapse callback to TreeView. This callback is triggered when a node that has children is clicked.

Does onCollapse make the most sense for the name, or would onToggle be a better fit?

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 9, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9480.surge.sh

A11y report: https://patternfly-react-pr-9480-a11y.surge.sh

thatblindgeye
thatblindgeye reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's being called when the tree view collapses and expands onToggle sounds like a better fit. Another option might be also adding an onExpand callback and calling it and onCollapse when applicable.

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Aug 15, 2023

Opted to divide the callbacks into onExpand and onCollapse because the opened state of the folder is internal.

tlabaj
tlabaj reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think onCollapse make sense.

Can you add some unit test for these please?

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Aug 16, 2023

@tlabaj Just onCollapse or onCollapse + onExpand?

Will add some tests.

tlabaj
tlabaj approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit 849cd75 into patternfly:main Aug 16, 2023
@MariaAga MariaAga mentioned this pull request Aug 25, 2023
Closed
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
@kmcfaul @nicolethoen
feat(TreeView): onCollapse callback (patternfly#9480)
c902a3a 
* feat(TreeView): onCollapse callback

* separate callbacks into collapse and expand

* add test
@renovate renovate bot mentioned this pull request Apr 2, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeView - add onCollapse function
4 participants
@kmcfaul @patternfly-build @tlabaj @thatblindgeye