chore(CodeBlock): update tests #9546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9546.surge.sh A11y report: https://patternfly-react-pr-9546-a11y.surge.sh |
tlabaj
requested changes
Sep 5, 2023
| const { asFragment } = render(<CodeBlockAction>action</CodeBlockAction>); | ||
| expect(asFragment()).toMatchSnapshot(); | ||
| }); | ||
| test('CodeBlock content renders with class pf-v5-c-code-block__content by default', () => { |
There was a problem hiding this comment.
Can you follow what Adam is doing in his PR for updating our test to not have hard coded styles. This will make it easier when updating versions of PF classes in the future.
thatblindgeye
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Just some comments below, can we also add tests for:
- in CodeBlock, that passing
actionsworks (could just pass a div with a simple string and check that the string renders) - basic snapshot tests for CodeBlockAction and CodeBlockCode
- In CodeBlockCode, that the
pf-v5-c-code-block__preclass renders by default and thatclassNamebeing passed works
packages/react-core/src/components/CodeBlock/__tests__/CodeBlock.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/CodeBlock/__tests__/CodeBlockAction.test.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
approved these changes
Sep 27, 2023
tlabaj
approved these changes
Oct 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9533