chore(Button): update tests #9558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9558.surge.sh A11y report: https://patternfly-react-pr-9558-a11y.surge.sh |
thatblindgeye
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Some files changes noted below. Could we also add tests for the following:
- when
isActiveis passed - A test for checking the component renders without children (similar to the first Alert test)
- having a single snapshot test for a basic button
- when passing a custom className
- checking that the
pf-v5-c-buttonclass is applied by default - checking that
pf-m-progressis applied whenever isLoading is either true or false- also checking that pf-m-progress is not applied for the above if the variant is "plain"
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Button/__tests__/Button.test.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
approved these changes
Sep 26, 2023
tlabaj
approved these changes
Oct 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9527