Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): legendAllowWrap function generates an error #9719

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(charts): legendAllowWrap function generates an error #9719

merged 1 commit into from
Oct 9, 2023

Conversation

dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Oct 7, 2023 •
edited
Loading

This ensures legend props are not undefined in the Chart's useEffect hook.

#9718

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 7, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9719.surge.sh

A11y report: https://patternfly-react-pr-9719-a11y.surge.sh

@dlabrecq dlabrecq force-pushed the 9718-legendAllowWrap branch 2 times, most recently from 4373610 to 1a57201 Compare October 8, 2023 05:03
gitdallas
gitdallas approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: instead of nested ifs, could do if (typeof legendAllowWrap === 'function' && computedLegend?.props)

@dlabrecq dlabrecq force-pushed the 9718-legendAllowWrap branch from 1a57201 to 5ec54b6 Compare October 9, 2023 02:03
@tlabaj tlabaj merged commit 5b4cbf4 into patternfly:main Oct 9, 2023
10 checks passed
@tlabaj tlabaj mentioned this pull request Oct 9, 2023
Closed
@dlabrecq dlabrecq deleted the 9718-legendAllowWrap branch October 11, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj approved these changes

@gitdallas gitdallas gitdallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlabrecq @patternfly-build @gitdallas @tlabaj