-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BulkSelect component #146
Conversation
|
||
### Bulk select with all option | ||
|
||
To display an option for seleting all data at once, pass `canSelectAll` flag together with `totalCount` of data entries. You can also remove the page select option by setting `isDataPaginated` to `false`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a typo on seleting (selecting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrew-ronaldson fixed, thank you 🙂
...module/patternfly-docs/content/extensions/component-groups/examples/BulkSelect/BulkSelect.md
Outdated
Show resolved
Hide resolved
splitButtonOptions={{ | ||
items: [ | ||
<MenuToggleCheckbox | ||
ouiaId={`${ouiaId}-checkbox`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to provide some sort of MenuToggleCheckboxProps
. We can omit the onChange
and isChecked
props, but the rest should be configurable.
items: [ | ||
<MenuToggleCheckbox | ||
ouiaId={`${ouiaId}-checkbox`} | ||
id={BulkSelectValue.page} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't use constant like this. There will be ID errors with multiple bulk selects on a page.
789c971
to
6674c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that when you use a keyboard to select an item from the menu, the focus then gets lost. I believe the focus should return to the toggle after an item is selected.
@nicolethoen Oh yeah, I've added the PF flag for that thing. The problem is that it does not work for the splitButtonOptions. As far as I see correctly in the PF MenuToggle implementation, the ref is being passed to the |
@Hyperkid123 @andrew-ronaldson @nicolethoen do you think we can get it to pre-release as it is, so we can start using it in DataView development? The focus thing will be fixed as a follow-up depending on the response from PF devs. |
RHCLOUD-33144
Added BulkSelect component to component groups with docs and tests