Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PARANAMER-26] Upgrade QDox to 2.x #16

Closed
wants to merge 1 commit into from

Conversation

rfscholte
Copy link
Collaborator

I've changed a couple the method signatures in favour of QDox. Not sure what the impact is of the public methods, please verify yourself.
Most important changes:

  • use JavaProjectBuilder instead of JavaDocBuilder
  • Introduce JavaConstructor
  • Arrays have become Lists when there's a predictable order, otherwise Collections

@paul-hammant
Copy link
Owner

merged on the command line (as I messed up by not pushing to GH some local changes)

@rfscholte
Copy link
Collaborator Author

Looking at https://github.com/paul-hammant/paranamer/commits/master it seems like these changed hasn't been added to the master. Also after verifying the code, it still uses JavaDocBuilder, that can't be right...

@paul-hammant
Copy link
Owner

You're right about JavaDocBuilder. I did the merge, and your two commits
appear in the commit history of master.

I found it easier to merge my changes (that'd I'd not pushed by accident)
on top of yours on a fresh checkout of yours, then push back to mine. I
wonder why it messed up

On Sat, Aug 16, 2014 at 5:52 PM, Robert Scholte notifications@github.com
wrote:

Looking at https://github.com/paul-hammant/paranamer/commits/master it
seems like these changed hasn't been added to the master. Also after
verifying the code, it still uses JavaDocBuilder, that can't be right...


Reply to this email directly or view it on GitHub
#16 (comment).

@paul-hammant
Copy link
Owner

Oh jeez, what a mess -
3c0ec5d#diff-d41d8cd98f00b204e9800998ecf8427e

On Sat, Aug 16, 2014 at 6:30 PM, Paul Hammant paul@hammant.org wrote:

You're right about JavaDocBuilder. I did the merge, and your two commits
appear in the commit history of master.

I found it easier to merge my changes (that'd I'd not pushed by accident)
on top of yours on a fresh checkout of yours, then push back to mine. I
wonder why it messed up

On Sat, Aug 16, 2014 at 5:52 PM, Robert Scholte notifications@github.com
wrote:

Looking at https://github.com/paul-hammant/paranamer/commits/master it
seems like these changed hasn't been added to the master. Also after
verifying the code, it still uses JavaDocBuilder, that can't be right...


Reply to this email directly or view it on GitHub
#16 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants