Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter error array by unique values #1

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

paul-stolk-webdiensten
Copy link
Owner

Description (*)

Added an array_unique to prevent duplicate errors.

Fixed Issues (if relevant)

  1. graphql-input provides to Customer as many errors as appeared instead of last one like on Magento Storefront magento/graphql-ce#416: graphql-input provides to Customer as many errors as appeared instead of last one like on Magento Storefront graphql-input provides to Customer as many errors as appeared instead of last one like on Magento Storefront magento/graphql-ce#416

Manual testing scenarios (*)

  1. Create a product with two or more required customizable options
  2. Add the product with GraphQl to the cart, with for example:
mutation {
  addSimpleProductsToCart(
    input: {
      cart_id: "5qqnw42QYVX5SIHRFHETKhDQfb0mDe5K"
      cart_items: [
        {
          data: {
            quantity: 1
            sku: "416"
          }
        }
      ]
    }
  ) {
    cart {
      items {
        id
        product {
          sku
          stock_status
        }
        quantity
      }
    }
  }
}

Questions or comments

Contribution checklist (*)

  • [ x ] Pull request has a meaningful description of its purpose
  • [ x ] All commits are accompanied by meaningful commit messages
  • [ x ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ x ] All automated tests passed successfully (all builds are green)

@paul-stolk-webdiensten paul-stolk-webdiensten merged commit de92f12 into 2.3-develop Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant