Skip to content

Commit

Permalink
Fix assertion after r237102
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=190459

* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
Shipping Safari still uses shouldGoToBackForwardListItem, so only assert on
newer platforms like we do in WKPageSetPageLoaderClient.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@237111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
achristensen@apple.com committed Oct 15, 2018
1 parent fe1658d commit 1a33581
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
10 changes: 10 additions & 0 deletions Source/WebKit/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
2018-10-15 Alex Christensen <achristensen@webkit.org>

Fix assertion after r237102
https://bugs.webkit.org/show_bug.cgi?id=190459

* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
Shipping Safari still uses shouldGoToBackForwardListItem, so only assert on
newer platforms like we do in WKPageSetPageLoaderClient.

2018-10-15 Alex Christensen <achristensen@webkit.org>

Shrink more enum classes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ using namespace WebCore;
InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient(const WKBundlePageLoaderClientBase* client)
{
initialize(client);
#if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED > 101400
// Deprecated callbacks.
ASSERT(!m_client.shouldGoToBackForwardListItem);
#endif
}

void InjectedBundlePageLoaderClient::willLoadURLRequest(WebPage& page, const ResourceRequest& request, API::Object* userData)
Expand Down

0 comments on commit 1a33581

Please sign in to comment.