Make RepositoryEntityMultipartHttpMessageConverter resolve json HttpMessageConverter when it is being used. #2189
+20
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essageConverter when it is being used. In spring-data-rest 4.3.5, the logic has changed and now the entity class is being passed to `canRead()` and `read()` instead of `PersistentEntityResource`. This means that a different converter can be triggered based on which entity is being passed, so we need to select the correct HttpMessageConverter at the point when we know the class that is being read. This also allows users to configure their own specific HttpMessageConverters for their entities.
|
There is another problem introduced in that version of spring-data-rest (spring-projects/spring-data-rest#2425), which may make the tests fail anyways on spring boot 3.3.5. I already wanted to get this PR opened because I had to fix this issue anyways during my investigation into why our contentgrid-spring tests were failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spring-data-rest 4.3.5 (spring boot 3.3.5), the logic has changed and now the entity
class is being passed to
canRead()andread()instead ofPersistentEntityResource.This means that a different converter can be triggered based on which
entity is being passed, so we need to select the correct HttpMessageConverter
at the point when we know the class that is being read.
This also allows users to configure their own specific
HttpMessageConverters for their entities.