Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use Ox as a SAX handler #49

Merged
merged 4 commits into from
Jul 18, 2014
Merged

Option to use Ox as a SAX handler #49

merged 4 commits into from
Jul 18, 2014

Conversation

krasnoukhov
Copy link
Collaborator

I've run feedjira-benchmarks on this and it definitely looks like Ox makes sax-machine more than 30% faster.

Here are the results:

Rehearsal -----------------------------------------------
feedjira     15.490000   0.070000  15.560000 ( 15.703976)
feedjira-ox  10.530000   0.030000  10.560000 ( 10.675326)
------------------------------------- total: 26.120000sec

                  user     system      total        real
feedjira     15.640000   0.060000  15.700000 ( 15.850888)
feedjira-ox  10.520000   0.030000  10.550000 ( 10.667229)

others-benchmark

@krasnoukhov
Copy link
Collaborator Author

We've worked with @ohler55 to make Ox fully compatible with Nokogiri in terms of newlines processing. Now, after a few patches (thanks Peter!) I can claim it is compatible.

So, I have both sax-machine and feedjira suites passing:
https://travis-ci.org/krasnoukhov/sax-machine/builds/27847719
https://travis-ci.org/krasnoukhov/feedjira/builds/27848889

I think this is ready to merge once ox 2.1.2 is released. @pauldix, please let me know what you think.

krasnoukhov added a commit that referenced this pull request Jul 18, 2014
Option to use Ox as a SAX handler
@krasnoukhov krasnoukhov merged commit 99a23cc into pauldix:master Jul 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant