Merge pull request #1245 from les-sosna/fix_instances_leak

Fix SctpTransport::Instances leak
paullouisageneau · Aug 29, 2024 · 57e06d8 · 57e06d8
2 parents 27e807f + 5c50c69
commit 57e06d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/impl/sctptransport.cpp b/src/impl/sctptransport.cpp
@@ -82,7 +82,7 @@ class SctpTransport::InstancesSet {
 	std::shared_mutex mMutex;
 };
 
-SctpTransport::InstancesSet *SctpTransport::Instances = new InstancesSet;
+std::unique_ptr<SctpTransport::InstancesSet> SctpTransport::Instances = std::make_unique<InstancesSet>();
 
 void SctpTransport::Init() {
 	usrsctp_init(0, SctpTransport::WriteCallback, SctpTransport::DebugCallback);

diff --git a/src/impl/sctptransport.hpp b/src/impl/sctptransport.hpp
@@ -127,7 +127,7 @@ class SctpTransport final : public Transport, public std::enable_shared_from_thi
 	static void DebugCallback(const char *format, ...);
 
 	class InstancesSet;
-	static InstancesSet *Instances;
+	static std::unique_ptr<InstancesSet> Instances;
 };
 
 } // namespace rtc::impl