unifi_port_forward enabled should default to true

[jippi]

Port forwards are created with enabled = false currently, with no way to actually enable them via terraform since enabled is deprecated

Fixes #255

[dunderrrrrr]

@paultyng whats the status on this one? It should be merged imo.

[joshuaspence]

Changing the default value is a breaking change. This field has been marked as deprecated for almost 3 years so let's just remove it.

[MaienM]

But with the default being false people are currently required to pass enabled = true despite this being a deprecated field to actually use the port forward, right? So just removing it would also be a breaking change for pretty much everyone that is using this resource at the moment.

[jippi]

I agree, it would for sure break a ton of code bases without a major release bump

[joshuaspence]

But with the default being false people are currently required to pass enabled = true despite this being a deprecated field to actually use the port forward, right? So just removing it would also be a breaking change for pretty much everyone that is using this resource at the moment.

Good point