Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all fuzz tests #412

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Enable all fuzz tests #412

merged 1 commit into from
Aug 3, 2021

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Aug 3, 2021

After running for a while, no panic occurred so it seems that let mut result = self + Decimal::ONE; was the sole culprit.
It is worth noting that although no panic occurred on my local tests and no panic can occur after running the fuzz targets for many years, all explicit arithmetic operator (+, *, -, %, etc) should be audited to catch any possible corner-case.

@paupino
Copy link
Owner

paupino commented Aug 3, 2021

Good catch re the +1. At some stage it may be worth breaking out the fuzz tests so that we can be more granular when they run. For now though, this is great!

@paupino paupino merged commit 3c0f76b into paupino:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants