feat: add PDM_MULTIRUN_CURRENT environment variable #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomWeldon
pushed a commit
to DomWeldon/partialdispatch
that referenced
this pull request
Sep 19, 2023
DomWeldon
pushed a commit
to DomWeldon/partialdispatch
that referenced
this pull request
Sep 19, 2023
DomWeldon
force-pushed
the
feature/current-version-as-env-var
branch
from
d843ca5
to
f9e9516
Compare
pawamoy
reviewed
Sep 19, 2023
README.md
Outdated
| @@ -98,7 +102,8 @@ import sys | |||
| MULTIRUN = os.getenv("PDM_MULTIRUN", "0") == "1" | |||
|
|
|||
| if MULTIRUN: | |||
| py = f"{sys.version_info[0]}.{sys.version_info[1]}" # 3.8, 3.9, etc. | |||
| int_name = os.getenv('PDM_MULTIRUN_CURRENT', '') | |||
| py = f"{int_name}: {sys.version_info[0]}.{sys.version_info[1]}" # py38: 3.8, py39: 3.9, etc. | |||
There was a problem hiding this comment.
Maybe show a venv name that is not just the Python version, to make it more explicit?
build: 3.8, tests: 3.11 etc.
There was a problem hiding this comment.
Suggested change
| py = f"{int_name}: {sys.version_info[0]}.{sys.version_info[1]}" # py38: 3.8, py39: 3.9, etc. | |
| py = f"{int_name}: {sys.version_info[0]}.{sys.version_info[1]}" # build: 3.8, tests: 3.9, etc. |
pawamoy
reviewed
Sep 19, 2023
DomWeldon
force-pushed
the
feature/current-version-as-env-var
branch
from
f9e9516
to
f69b283
Compare
|
Altered accordingly, added a bit more to the docs on that feature and the example to make it clearer. Side point - wasn't sure what the preferred line length is for markdown here, I assumed 80? |
|
CI issue should be fixed by #6 |
pawamoy
reviewed
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small change to make the name of the current interpreter or virtual environment available under the environment variable
PDM_MULTIRUN_CURRENT. This is particularly useful for cases when the name of a virtual environment may not be equal to the specific python version.