Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Local Search open in same tab does not work when pressing enter on keyboard #270

Closed
redsx16 opened this issue Dec 26, 2021 · 5 comments · Fixed by #432
Closed

[BUG] Local Search open in same tab does not work when pressing enter on keyboard #270

redsx16 opened this issue Dec 26, 2021 · 5 comments · Fixed by #432
Labels
🐞 Bug Something isn't working

Comments

@redsx16
Copy link

redsx16 commented Dec 26, 2021

Deployment details:

  • App version [e.g. v1.7.4]: 2.2.0
  • Platform [e.g. amd64, arm64, arm/v7]:
  • Docker image tag [e.g. latest, multiarch]: latest

Bug description:

When searching for an app with local search and pressing enter the setting to open in the same tab does not work. If the user clicks on the app it will open in the same tab.


Steps to reproduce:

  1. Set Search Default provider to 'Local Search'
  2. Set Open search results in the same tab to 'True'
  3. Save
  4. Search for a local application and press enter (app opens in a new tab)
  5. Repeat step 4 but instead click on the app (app opens in the same tab)
@pmjklemm
Copy link
Contributor

pmjklemm commented Jan 4, 2022

There is a workaround: just set the search provider (settings > search) to anything but local.

@TheAnachronism
Copy link

TheAnachronism commented Apr 4, 2022

There is a workaround: just set the search provider (settings > search) to anything but local.

Yeah, but this makes the search usage for applications / bookmarks unusable.

@rcdailey
Copy link

When are we getting a fix for this?

theryxs added a commit to theryxs/flame that referenced this issue Aug 29, 2022
@sn0am
Copy link

sn0am commented Dec 13, 2022

This issue still seems to be there. I built an image from the latest files and search in same tab still opens a new tab every time.

@pmjklemm
Copy link
Contributor

@sn0am yes, I wrote a fix in #284 but it is not merged yet, idk

@pawelmalak pawelmalak linked a pull request Jul 20, 2023 that will close this issue
@pawelmalak pawelmalak added the 🐞 Bug Something isn't working label Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants