Fixes crash with #emit and unused functions #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The crash only happens when the parser skips the initialization of functions with SYSREQ. I.e. if we don't call the functions with
#emit SYSREQ
, the compiler crashs. BUT it doesn't work with public-functions.Crash:
Ok:
This PR adds a member variable called
func_skipped
in the symbol struct. This variable keeps track if the function was skipped. Also, in the #emit we check whether we need to mark the native-function as read or not.