Merge pull request #824 from DyfanJones/copy_source_param_redirect

prevent copy_source parameter being handled a second time for redirected calls
paws-r · Aug 29, 2024 · ddd59d4 · ddd59d4
2 parents 2e950ed + 6ac45b8
commit ddd59d4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/paws.common/DESCRIPTION b/paws.common/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: paws.common
 Type: Package
 Title: Paws Low-Level Amazon Web Services API
-Version: 0.7.5
+Version: 0.7.6
 Authors@R: c(
         person("David", "Kretch", email = "david.kretch@gmail.com", role = "aut"),
         person("Adam", "Banker", email = "adam.banker39@gmail.com", role = "aut"),

diff --git a/paws.common/NEWS.md b/paws.common/NEWS.md
@@ -1,3 +1,6 @@
+# paws.common 0.7.6
+* fix `handle_copy_source_param` encoding redirected calls.
+
 # paws.common 0.7.5
 * build endpoint with host_prefix (#804), thanks to @joseale2310 and @lyschoening for raising issue.
 * fix `unix_time` ensure seconds is numeric (#804), thanks to @joseale2310 and @lyschoening for raising issue.

diff --git a/paws.common/R/custom_s3.R b/paws.common/R/custom_s3.R
@@ -484,7 +484,8 @@ set_request_url <- function(original_endpoint,
 
 ################################################################################
 handle_copy_source_param <- function(request) {
-  if (!(request$operation$name %in% c("CopyObject", "CopyPart"))) {
+
+  if (!(request$operation$name %in% c("CopyObject", "CopyPart")) | isTRUE(request$context$s3_redirect)) {
     return(request)
   }
   source <- request$params$CopySource