Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-81 Display port number on start-domain with --debug=true option #4387

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Dec 14, 2019

This is a bug fix. (#4386)

Current GFLauncher recognizes only old-style JDWP option (-Xrunjdwp), but by default from template new one (-agentlib:jdwp) is used. With the effect of port not parsed from option (defaulted to -1),

is not fulfilled, and expected message is not logged.

Testing Performed

After full build following performed:

unzip  appserver/distributions/payara/target/payara.zip
./payara5/glassfish/bin/asadmin start-domain --debug=true

which resulted in

Waiting for domain1 to start ............
Successfully started the domain : domain1
domain  Location: /tmp/payara5/glassfish/domains/domain1
Log File: /tmp/payara5/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
Debugging is enabled.  The debugging port is: 9009
Command start-domain executed successfully.

Testing Environment

  • Linux
  • OpenJDK Runtime Environment (build 1.8.0_232-b09)
  • Maven 3.6.3

@pzygielo pzygielo marked this pull request as ready for review December 15, 2019 07:45
@dmatej
Copy link
Contributor

dmatej commented Dec 15, 2019

Created internal issue CUSTCOM-81

@Cousjava Cousjava changed the title Display port number on start-domain with --debug=true option CUSTCOM-81 Display port number on start-domain with --debug=true option Dec 17, 2019
@Cousjava
Copy link
Contributor

Jenkins test please

@MarkWareham MarkWareham added PR: CLA CLA submitted on PR by the contributor community-contribution labels Dec 17, 2019
@dmatej dmatej merged commit 1079fa9 into payara:master Jan 8, 2020
@@ -1,7 +1,7 @@
/*
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
*
* Copyright (c) 2008-2015 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2008-2019 Oracle and/or its affiliates. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a question: why you updated this copyright year?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the one already in place, hidden at

// Portions Copyright [2016-2019] [Payara Foundation and/or its affiliates]

Have not revoked OCA, so it's still kind of true 😉 I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmatej I'm going to check my pending open PRs.

@pzygielo pzygielo deleted the debug branch January 8, 2020 11:59
@pzygielo
Copy link
Contributor Author

pzygielo commented Jan 9, 2020

Just for reference - one sonar finding fixed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants