Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-8100: fixing issue when totalizing buckets for prometheus format #6500

Conversation

breakponchito
Copy link
Contributor

@breakponchito breakponchito commented Dec 6, 2023

Fix buckets counting for Prometheus format

Description

This is a fix for an issue to totalize the occurrences of bucket values

Important Info

Blockers

Testing

New tests

Testing Performed

Manual testing by executing metrics application with histogram and timer metrics and custom configuration for percentiles and buckets

image

TCK results for metrics:
image

result from samples:
image

steps to reproduce on the ticket:

https://payara.atlassian.net/browse/FISH-8100

Testing Environment

windows 11, azul jdk 11, maven 3.9.5 / ubuntu 20.04, azul jdk 11, maven 3.8.6

Documentation

Notes for Reviewers

@breakponchito
Copy link
Contributor Author

Jenkins test please

@breakponchito
Copy link
Contributor Author

Jenkins test please

@breakponchito
Copy link
Contributor Author

Jenkins test please

2 similar comments
@breakponchito
Copy link
Contributor Author

Jenkins test please

@breakponchito
Copy link
Contributor Author

Jenkins test please

@breakponchito
Copy link
Contributor Author

Jenkins test please

Copy link
Contributor

@luiseufrasio luiseufrasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@breakponchito breakponchito merged commit f95f31d into payara:master Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants