FISH-8688 improvement: optimize MR-jar class loading

[lprimak]

Description

Optimize multi-release JAR processing, remove resource leak from MR-JarFile remaining open
Opening MR-Jars correctly by using RUNTIME_VERSION
fixes #6554

Testing Performed

Deploy original reproducer for this issue

Testing Environment

Any

[RInverid]

I get a deployment failure with this PR - an @DependsOn annotation fails to resolve another singleton in the same ejb package. (the singleton that is depended on implements an interface, and that interface is injected into the singleton with the @DependsOn annotation)

[lprimak]

@RInverid do you have a reproducer or at least a stack trace? There isn’t much to go on in your comment

[RInverid]

Not yet, but I have more practical feedback: this MR does not load Bouncycastle libs if running on JDK 17. BC libs are multirelease, but they only have class files for jdk9. Your PR skips loading BC classes becuase it cannot find classes for jdk17

[lprimak]

Hmmmm. I specifically tested BC libs in 11 (but not 17) so I am not sure how 17 would be any different.
Looking forward to a reproducer.

[Pandrex247]

Had a quick look myself, I think you can use the reproducer provided against the original change PR to see the error (albeit against embedded): https://github.com/ctabin/gf-test-lucene

Without this PR, it works as it's able to load the Analyzer class.
With this PR, issues start arising again with it unable to find the Analyzer class

Not yet determined the failing difference Yet™

[lprimak]

Ok, I didn't realize that commit was not only optimization but a bug fix. I re-incorporated the bug fix into this PR and tested it with https://github.com/ctabin/gf-test-lucene and it works

[RInverid]

Thanks for the changes, I re-tested this MR. The deployment time and memory Issues are seeing are less of an issue, but still present. Probably because the problematic change (JarFile jar = new JarFile etc) is still called, but significantly less often.

[lprimak]

@RInverid how about now?

[lprimak]

Jenkins test

[lprimak]

Jenkins test please

[RInverid]

Yes this resolves my issues, as I've also found with my testing. Not sure what the change in ProtectedJarFile does though, its at least not necessary to resolve my issues according to my testing.

[Pandrex247]

Thanks both! 👌