FISH-8855-Added Auto name for deployment group #6784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lp text. (saves making another autoname help text). Changed dgNew.jsf to include the checkbox for autoname and added code fro, instanceNew.inc to replicate the process of autonaming an instance but use it for a deployment group instead.
kalinchan
reviewed
Jun 27, 2024
appserver/admingui/cluster/src/main/resources/org/glassfish/cluster/admingui/Strings.properties
Outdated
Show resolved
Hide resolved
aubi
reviewed
Jun 28, 2024
appserver/admingui/cluster/src/main/resources/org/glassfish/cluster/admingui/Strings.properties
Show resolved
Hide resolved
…w deployment group is specific to deployment groups.
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jul 2, 2024
…epGroup FISH-8855-Added Auto name for deployment group
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jul 5, 2024
…epGroup FISH-8855-Added Auto name for deployment group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FISH-8855 added auto name for deployment group
Description
I have made changes to the strings.properties file so that instead of saying autoname instance, it says autoname instance/deployment group so it saves creating another autoname.help text.
Changed dgNew.jsf to include the checkbox button and changed the commands block for the new button so that the Deployment group label does not show as required (as autoname is an option) and if autoname is selected, it will use the same code as the instance autoname.
Important Info
Blockers
Testing
New tests
Testing Performed
Built and ran the server, made sure it was working. Tested auto naming multiple deployment groups and instances to make sure both worked correctly. Tested leaving everything blank to display error messages and tested setting own name + ticking the box to make sure that if the label is populated, it will default the name to that even if the box is checked.
Testing Environment
Documentation
Notes for Reviewers
I could of made the same exact functions that the instance auto name uses and changed to deployment group but I felt it would be unnecessary code.