Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-9098: fix for deployments caused by referenced resources from apps #6852

Conversation

breakponchito
Copy link
Contributor

@breakponchito breakponchito commented Aug 1, 2024

This is a fix to a reported bug caused by referenced resources used on app's

Description

Important Info

Blockers

Testing

New tests

Testing Performed

Manual testing on the server following described steps on the following tickets:

step 1: create instance and start:
image

step 2: create jdbc resource without assigned to an specific target
image

step3: deploy application to the instance created: clusterjsp and SimpleJndiLookup-1.0-SNAPSHOT

Observe components section for both:

image

image

step 4: Stop the instance and domain

step 5: Start the domain again, now you can't see any error during startup, this means the issue of the resource is fixed and if we look the Modules and Components for the applications we will see the details for it each application and both should look the same as previous test before to restart server:

image

image

Testing Environment

Ubuntu 20.04, azul jdk 11, maven 3.8.6

Documentation

Notes for Reviewers

@breakponchito
Copy link
Contributor Author

Jenkins test please

Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reintroduces FISH-6659

  • Start the DAS
  • Create an instance and start it
  • Deploy clusterjsp specifically to that instance
  • Observe that it lists various components e.g. ClearSession, HaJsp...
  • Restart the DAS
  • The components will no longer be shown

@breakponchito
Copy link
Contributor Author

Jenkins test please

@breakponchito
Copy link
Contributor Author

This reintroduces FISH-6659

  • Start the DAS
  • Create an instance and start it
  • Deploy clusterjsp specifically to that instance
  • Observe that it lists various components e.g. ClearSession, HaJsp...
  • Restart the DAS
  • The components will no longer be shown

I already fixed the issue now is maintaining the details of the components list without any issue on logs and the UI view

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 merged commit d2fe891 into payara:main Aug 5, 2024
1 check passed
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Aug 13, 2024
…eployments-caused-by-resources

FISH-9098: fix for deployments caused by referenced resources from apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants