Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-9197 Masking #6906

Merged
merged 1 commit into from
Aug 29, 2024
Merged

FISH-9197 Masking #6906

merged 1 commit into from
Aug 29, 2024

Conversation

Viii3
Copy link
Contributor

@Viii3 Viii3 commented Aug 23, 2024

Description

  • Resolves FISH-9197

Important Info

Blockers

Testing

New tests

Testing Performed

Built and started the server, changed the admin password via the admin gui, checked the logs to see if the new password appeared.

Testing Environment

Maven home: 3.9.6
Java version: 11.0.23, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

Documentation

Notes for Reviewers

@breakponchito
Copy link
Contributor

already tested now the password is masked:
image

@breakponchito breakponchito self-requested a review August 29, 2024 00:13
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Viii3 Viii3 merged commit 4a8ca2e into payara:main Aug 29, 2024
1 check passed
@Viii3 Viii3 deleted the FISH-9197-Logging branch September 3, 2024 08:41
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants