-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lost tab stop when keyboard cycling thru modal dialog #69
Comments
+1 on this issue. This appears to be a bug. Focus is being placed back on the modal container and the anchor/button that triggered the modal. Investigating from my end and will report back with any updates, but for now here's a little script to help diagnose if others want to take a look as well Running this from console: $('*').on('focus', function() {
console.log($(this));
}); And a little screencast showing the odd focus behavior coming back on the modal and mysterious button that triggered the modal somehow: http://youtu.be/RycKVnmaKtE |
This was some hack done to support shift+tab behaviour. http://getbootstrap.com/javascript/#modals doesn't support shift+tabbing inside modal container. |
Will this ever be fixed correctly? It really isn't usable to a screen reader user and is confusing to a keyboard user because focus gets lost (even if it is temporary). |
Please ignore #69 (comment). Even if i remove modal plugin code, the problem exists. This problem is inherited from http://getbootstrap.com/javascript/#modals . In order to test: The plugin will just make shift+tab work. |
I modified this to keep the focus within the modal dialog as the user tabs and shift-tabs through the items. Tested with VoiceOver in Safari, JAWS 17 and NVDA in Firefox on Windows 10
I modified this to keep the focus within the modal dialog as the user tabs and shift-tabs through the items. Tested with VoiceOver in Safari, JAWS 17 and NVDA in Firefox on Windows 10
Fixes #69 Incorrect focus trap in modal dialog
Using the demo page, open the modal dialog example. Note that when you tab and reach the save changes button, pressing tab one more time does not show anything visibly focused. Pressing tab again with cycle to the close X button at the top of the dialog. The extra tab stop is problematic and should be removed. In my use of the modal in Readium, the extra tab stop goes to the URL bar (tested in Safari).
The same problem happens when shift-tabbing through the modal dialog. With focus on the close x, pressing shift-tab causes focus to be lost. Pressing shift-tab again will reach the Save Changes button in the modal dialog.
The text was updated successfully, but these errors were encountered: