Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: channel use struct #100

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

baerwang
Copy link
Contributor

No description provided.

@daveshanley
Copy link
Member

Can you help me understand the value of this?

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (0a73ef5) to head (41318b2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   99.80%   99.74%   -0.06%     
==========================================
  Files          28       28              
  Lines        2501     3152     +651     
==========================================
+ Hits         2496     3144     +648     
- Misses          5        8       +3     
Flag Coverage Δ
unittests 99.74% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley daveshanley merged commit 7b4e021 into pb33f:main Oct 21, 2024
2 of 3 checks passed
@baerwang baerwang deleted the style/optimize-code branch October 22, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants