Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.39 #45

Merged
merged 6 commits into from
Jan 12, 2024
Merged

v0.0.39 #45

merged 6 commits into from
Jan 12, 2024

Conversation

daveshanley
Copy link
Member

Added checks after hammering the validator with wiretap.

wiretap is giving it a run for its money

Signed-off-by: Dave Shanley <dave@quobix.com>
Signed-off-by: Dave Shanley <dave@quobix.com>
Signed-off-by: Dave Shanley <dave@quobix.com>
Signed-off-by: Dave Shanley <dave@quobix.com>
Signed-off-by: Dave Shanley <dave@quobix.com>
@daveshanley
Copy link
Member Author

This will drop coverage for a bit, but it's important for downstream projects I have going.

Signed-off-by: Dave Shanley <dave@quobix.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4502d66) 100.00% compared to head (1d7ccd0) 99.20%.

Files Patch % Lines
responses/validate_response.go 33.33% 6 Missing ⚠️
parameters/path_parameters.go 80.00% 1 Missing ⚠️
parameters/validate_parameter.go 85.71% 1 Missing ⚠️
requests/validate_body.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #45      +/-   ##
===========================================
- Coverage   100.00%   99.20%   -0.80%     
===========================================
  Files           19       19              
  Lines         1116     1137      +21     
===========================================
+ Hits          1116     1128      +12     
- Misses           0        9       +9     
Flag Coverage Δ
unittests 99.20% <72.72%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley daveshanley merged commit fc980db into main Jan 12, 2024
1 check passed
@daveshanley daveshanley deleted the wiretap branch January 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants