Skip to content

Commit

Permalink
Drop support for Python 3.5 (qiskit-community#1227)
Browse files Browse the repository at this point in the history
* Drop support for Python 3.5

This commit drops support for running with python 3.5. It marks the
minimum supported version of the package as python 3.6, removes python
3.5 package pins, removes the 3.5 CI jobs, and removes the warning on
python 3.5. Looking at the PyPI stats since the deprecation period
started the number of users on Python 3.5 has diminished significantly,
but not disappeared. There were 98 downloads with pip from pypi out of
total of 15,357 total pip downloads in the last 30 days. Compared to the
roughly 10% figure when we deprecated Python 3.5.

Merging this means we can not release until after the documented EoL
date for Python 3.5 support of September 13. This shouldn't be a problem
because with Qiskit/qiskit#4767 we will need to coordinate the
release of all the qiskit elements and are planning to do that after
09/13/2020.

It's worth noting that we should start planning to deprecate python 3.6
support sooner rather than later it goes EoL upstream at the end of
next year [1] and some of our other upstream dependencies (mainly numpy
et al) are going to remove support before the upstream Python EoL date
[2].

[1] https://devguide.python.org/#branchstatus
[2] https://numpy.org/neps/nep-0029-deprecation_policy.html

* Bump python version for mypy job
  • Loading branch information
mtreinish authored and pbark committed Sep 16, 2020
1 parent 278ff02 commit b92d73c
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.5]
python-version: [3.6]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
Expand Down Expand Up @@ -422,4 +422,4 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: coveralls || true
shell: bash
shell: bash
7 changes: 7 additions & 0 deletions releasenotes/notes/drop-py35-a1036a3d38f3d79a.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
upgrade:
- |
The deprecated support for running qiskit-aqua with Python 3.5 has
been removed. To use qiskit-aqua >=0.8.0 you will now need at
least Python 3.6. If you are using Python 3.5 the last version which will
work is qiskit-aqua 0.7.x.
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pylint>=2.4.4
pylintfileheader>=0.0.2
stestr>=2.0.0
ddt>=1.2.0,!=1.4.0
reno>=3.1.0;python_version>'3.5'
reno>=3.1.0
Sphinx>=1.8.3,!=3.1.0
sphinx-rtd-theme>=0.4.0
sphinx-tabs>=1.1.11
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
"Operating System :: MacOS",
"Operating System :: POSIX :: Linux",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
Expand All @@ -83,7 +82,7 @@
packages=setuptools.find_namespace_packages(exclude=['test*']),
install_requires=requirements,
include_package_data=True,
python_requires=">=3.5",
python_requires=">=3.6",
extras_require={
'torch': ["torch; sys_platform == 'linux' or (python_version < '3.8' and sys_platform != 'win32')"],
'cplex': ["cplex; python_version >= '3.6' and python_version < '3.8'"],
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
minversion = 2.1
envlist = py35, py36, py37, py38, lint
envlist = py36, py37, py38, lint
skipsdist = True

[testenv]
Expand Down

0 comments on commit b92d73c

Please sign in to comment.